Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved example data to the correct location (src/pint/data/examples/) #1350

Merged
merged 5 commits into from
Jul 28, 2022

Conversation

abhisrkckl
Copy link
Contributor

Fixes issue #1349 (and also issue #1345, which is a symptom of the more general issue #1349.)

@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #1350 (0330cd0) into master (bfa227e) will increase coverage by 0.36%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1350      +/-   ##
==========================================
+ Coverage   61.29%   61.66%   +0.36%     
==========================================
  Files          90       89       -1     
  Lines       20351    20233     -118     
  Branches     3646     3646              
==========================================
+ Hits        12475    12477       +2     
+ Misses       7089     6970     -119     
+ Partials      787      786       -1     
Impacted Files Coverage Δ
src/pint/models/timing_model.py 81.63% <0.00%> (ø)
src/pint/models/model_builder.py 93.50% <0.00%> (ø)
src/pint/models/pulsar_binary.py 76.24% <0.00%> (ø)
src/pint/observatory/observatories.py
src/pint/__init__.py 97.36% <0.00%> (+5.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfa227e...0330cd0. Read the comment docs.

@dlakaplan
Copy link
Contributor

Are those files called by any scripts? Have those scripts also been changed? Probably nothing calls them that is automatically run, but otherwise?

@abhisrkckl
Copy link
Contributor Author

Based on running grep:
J0613-sim.par.good is not used in any of the scripts.
NGC6440E.par.good is used in MCMC_walkthrough.broken and fit_NGC6440E_MCMC.py
J0030+0451_P8_15.0deg_239557517_458611204_ft1weights_GEO_wt.gt.0.4.fits is used in MCMC_walkthrough.broken
templateJ0030.3gauss is used in MCMC_walkthrough.broken

fit_NGC6440E_MCMC.py should work after moving these files as it accesses the example files via pint.config.examplefile function. (I have tested this.)

I don't know about MCMC_walkthrough.broken. Maybe it is planned to be fixed in the future?

@dlakaplan
Copy link
Contributor

Maybe it's better to remove those files which are not used by any example?

@paulray
Copy link
Member

paulray commented Jul 25, 2022

Please keep the NGC6440E and J0030 files.

@abhisrkckl
Copy link
Contributor Author

I have also checked the test scripts. Only J0613-sim.par.good can be safely deleted.

@aarchiba aarchiba merged commit 0c0a406 into nanograv:master Jul 28, 2022
@abhisrkckl abhisrkckl deleted the example-data-in-one-place branch May 1, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants