Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract single TOA as table #1381

Merged
merged 5 commits into from
Sep 6, 2022
Merged

Extract single TOA as table #1381

merged 5 commits into from
Sep 6, 2022

Conversation

dlakaplan
Copy link
Contributor

Extracting a single TOA as a TOA object does not work. But is there a reason we shouldn't enable a length=1 TOAs object? This allows that, and updates the docs slightly.

Addresses #1352

If this is a bad idea happy to shelve.

@dlakaplan
Copy link
Contributor Author

Currently includes a warning stating what it's doing. That could be removed it it's too annoying.

@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #1381 (481997d) into master (0d6aeaf) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1381      +/-   ##
==========================================
+ Coverage   62.25%   62.26%   +0.01%     
==========================================
  Files          89       89              
  Lines       20267    20270       +3     
  Branches     3653     3653              
==========================================
+ Hits        12617    12622       +5     
+ Misses       6860     6858       -2     
  Partials      790      790              
Impacted Files Coverage Δ
src/pint/toa.py 83.48% <100.00%> (+0.25%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dlakaplan
Copy link
Contributor Author

Changed warning -> info

@dlakaplan dlakaplan added the awaiting review This PR needs someone to review it so it can be merged label Aug 18, 2022
@dlakaplan
Copy link
Contributor Author

I think this is ready to merge as soon as the CI passes.

@aarchiba
Copy link
Contributor

Do we have any functions that expect single TOAs that should now accept single-TOA tables?

@dlakaplan
Copy link
Contributor Author

I'm not sure. Possibly some of the TOAs construction could do that, but I think you can already construct TOAs from other TOAs.

@paulray paulray merged commit f17ff97 into nanograv:master Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review This PR needs someone to review it so it can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants