-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract single TOA as table #1381
Conversation
Currently includes a warning stating what it's doing. That could be removed it it's too annoying. |
Codecov Report
@@ Coverage Diff @@
## master #1381 +/- ##
==========================================
+ Coverage 62.25% 62.26% +0.01%
==========================================
Files 89 89
Lines 20267 20270 +3
Branches 3653 3653
==========================================
+ Hits 12617 12622 +5
+ Misses 6860 6858 -2
Partials 790 790
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Changed warning -> info |
I think this is ready to merge as soon as the CI passes. |
Do we have any functions that expect single TOAs that should now accept single-TOA tables? |
I'm not sure. Possibly some of the |
Extracting a single TOA as a
TOA
object does not work. But is there a reason we shouldn't enable a length=1TOAs
object? This allows that, and updates the docs slightly.Addresses #1352
If this is a bad idea happy to shelve.