Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in dmxparse #1409

Merged
merged 1 commit into from
Sep 29, 2022
Merged

Fixed bug in dmxparse #1409

merged 1 commit into from
Sep 29, 2022

Conversation

dlakaplan
Copy link
Contributor

This fixes #1408, where the R1 and R2 times for dmxparse were the same.

@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Base: 62.42% // Head: 62.40% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (56cfbc5) compared to base (d0e2009).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1409      +/-   ##
==========================================
- Coverage   62.42%   62.40%   -0.03%     
==========================================
  Files          89       89              
  Lines       20355    20408      +53     
  Branches     3671     3698      +27     
==========================================
+ Hits        12707    12736      +29     
- Misses       6854     6876      +22     
- Partials      794      796       +2     
Impacted Files Coverage Δ
src/pint/utils.py 59.24% <100.00%> (ø)
src/pint/gridutils.py 44.21% <0.00%> (-4.75%) ⬇️
src/pint/fitter.py 82.89% <0.00%> (-0.16%) ⬇️
src/pint/models/timing_model.py 82.93% <0.00%> (-0.09%) ⬇️
src/pint/models/model_builder.py 93.50% <0.00%> (ø)
src/pint/toa.py 83.88% <0.00%> (+0.39%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dlakaplan
Copy link
Contributor Author

This is very small, if somebody (@paulray , @scottransom ) wants to check & merge.

@paulray paulray merged commit 6fce82e into nanograv:master Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with pint.utils.dmxparse 'dmxparse.out' file inconsistent with par file
2 participants