Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduces_correlated_errors as a class attribute of NoiseComponents #1424

Merged
merged 5 commits into from
Oct 27, 2022

Conversation

abhisrkckl
Copy link
Contributor

Fixes #1421

@abhisrkckl abhisrkckl added the awaiting review This PR needs someone to review it so it can be merged label Oct 20, 2022
@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Base: 62.71% // Head: 62.71% // No change to project coverage 👍

Coverage data is based on head (7159a37) compared to base (4fbb5bf).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1424   +/-   ##
=======================================
  Coverage   62.71%   62.71%           
=======================================
  Files          90       90           
  Lines       20483    20483           
  Branches     3533     3533           
=======================================
  Hits        12846    12846           
  Misses       6839     6839           
  Partials      798      798           
Impacted Files Coverage Δ
src/pint/models/noise_model.py 92.38% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@abhisrkckl
Copy link
Contributor Author

I think this is ready to merge.

@dlakaplan dlakaplan merged commit 2ec778e into nanograv:master Oct 27, 2022
@abhisrkckl abhisrkckl deleted the query-model-components branch December 2, 2022 20:39
@abhisrkckl abhisrkckl restored the query-model-components branch December 2, 2022 20:39
@abhisrkckl abhisrkckl deleted the query-model-components branch January 24, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review This PR needs someone to review it so it can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

introduces_correlated_errors should be a class attribute of NoiseComponents
2 participants