-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve test coverage and minor bug fixes #1444
Conversation
Codecov ReportBase: 62.70% // Head: 63.24% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1444 +/- ##
==========================================
+ Coverage 62.70% 63.24% +0.53%
==========================================
Files 90 90
Lines 20485 20487 +2
Branches 3534 3535 +1
==========================================
+ Hits 12846 12957 +111
+ Misses 6840 6745 -95
+ Partials 799 785 -14
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
I am done with this PR. There is a lot of room for improvement in this, but those can be part of future PRs. |
Added tests from un-merged PR #1446 |
This looks good. Ready to merge? |
Yes |
See #457