Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage and minor bug fixes #1444

Merged
merged 31 commits into from
Nov 16, 2022

Conversation

abhisrkckl
Copy link
Contributor

@abhisrkckl abhisrkckl commented Nov 11, 2022

See #457

@abhisrkckl abhisrkckl changed the title Improve coverage for pint.toa and minor bug fixes Improve test coverage for pint.toa and minor bug fixes Nov 11, 2022
tests/test_toa_writer.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Base: 62.70% // Head: 63.24% // Increases project coverage by +0.53% 🎉

Coverage data is based on head (e7b867e) compared to base (e9c41b6).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1444      +/-   ##
==========================================
+ Coverage   62.70%   63.24%   +0.53%     
==========================================
  Files          90       90              
  Lines       20485    20487       +2     
  Branches     3534     3535       +1     
==========================================
+ Hits        12846    12957     +111     
+ Misses       6840     6745      -95     
+ Partials      799      785      -14     
Impacted Files Coverage Δ
src/pint/derived_quantities.py 100.00% <100.00%> (+9.30%) ⬆️
src/pint/toa.py 87.28% <100.00%> (+3.42%) ⬆️
src/pint/residuals.py 67.48% <0.00%> (+0.81%) ⬆️
src/pint/orbital/kepler.py 98.19% <0.00%> (+4.07%) ⬆️
src/pint/phase.py 97.95% <0.00%> (+4.08%) ⬆️
src/pint/config.py 100.00% <0.00%> (+11.11%) ⬆️
src/pint/scripts/convert_parfile.py 83.33% <0.00%> (+83.33%) ⬆️
src/pint/scripts/compare_parfiles.py 100.00% <0.00%> (+100.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@abhisrkckl abhisrkckl changed the title Improve test coverage for pint.toa and minor bug fixes Improve test coverage and minor bug fixes Nov 11, 2022
@abhisrkckl
Copy link
Contributor Author

I am done with this PR. There is a lot of room for improvement in this, but those can be part of future PRs.

@abhisrkckl abhisrkckl added bug fix Bug fixing pull request awaiting review This PR needs someone to review it so it can be merged labels Nov 13, 2022
@abhisrkckl
Copy link
Contributor Author

Added tests from un-merged PR #1446

@dlakaplan
Copy link
Contributor

This looks good. Ready to merge?

@abhisrkckl
Copy link
Contributor Author

Yes

@dlakaplan dlakaplan merged commit c984cb9 into nanograv:master Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review This PR needs someone to review it so it can be merged bug fix Bug fixing pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants