Fix numerical slop reading in ASCII profiles, add tests. #1476
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Julia reported a problem making NICER TOAs after updates to this template fitting code. It was because I had begun to enforce strict parameter bounds, but profiles saved to ASCII templates can lose enough precision to fail the bounds check. This PR:
(1) will no longer silently fail when the likelihood is nonsense (because of a failed parameter check)
(2) will check ASCII profiles and, if they're close enough to parameter bounds, silently skootch them up or down to the bound
(3) adds tests for both changes