Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated docs for Apple silicon #1588

Merged
merged 5 commits into from
Jun 13, 2023
Merged

Updated docs for Apple silicon #1588

merged 5 commits into from
Jun 13, 2023

Conversation

dlakaplan
Copy link
Contributor

@dlakaplan dlakaplan commented Jun 8, 2023

@paulray
Copy link
Member

paulray commented Jun 8, 2023

I think this note: "NOTE: PINT requires longdouble arithmetic within numpy, which is currently not supported natively on M1/M2 Macs." should appear earlier, in addition to in the conda section. Perhaps right after the naming conflict note. Even people who install via pip and don't know what ananconda is need to be warned about the M1/M2 issue. Those people should be pointed to conda as the preferred solution.

@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (87d40cc) 68.07% compared to head (dbdcc4c) 68.07%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1588   +/-   ##
=======================================
  Coverage   68.07%   68.07%           
=======================================
  Files          98       98           
  Lines       22608    22608           
  Branches     3881     3881           
=======================================
  Hits        15391    15391           
  Misses       6270     6270           
  Partials      947      947           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

docs/installation.rst Outdated Show resolved Hide resolved
docs/installation.rst Outdated Show resolved Hide resolved
docs/installation.rst Show resolved Hide resolved
docs/installation.rst Outdated Show resolved Hide resolved
docs/installation.rst Outdated Show resolved Hide resolved
@abhisrkckl
Copy link
Contributor

I thing it should be a :: instead of : before the line

$ conda install -c conda-forge pint-pulsar

So that it appears in a code box.

@abhisrkckl
Copy link
Contributor

"pip uninstall" in the "Previous use of pip install --user" section appears broken into two lines.

@dlakaplan
Copy link
Contributor Author

"pip uninstall" in the "Previous use of pip install --user" section appears broken into two lines.

Not for me, but I removed a line break anyway

@abhisrkckl abhisrkckl linked an issue Jun 9, 2023 that may be closed by this pull request
@dlakaplan dlakaplan changed the title WIP: Updated docs for M1 Updated docs for Apple silicon Jun 12, 2023
@dlakaplan
Copy link
Contributor Author

Note that I had a weird issue when trying to install from conda on a M1 Mac. The conda was the x86 version. But conda install -c condo-forge pint-pulsar didn't work. It appeared to complete, but I got errors like:
https://stackoverflow.com/questions/70830755/intel-mkl-fatal-error-this-system-does-not-meet-the-minimum-requirements-for-us
when I ran it. The solution was to use conda just to create the environment but actually install using pip. Can anybody else test this?

@paulray
Copy link
Member

paulray commented Jun 13, 2023

Can we merge this or do you want to wait on your intel-mkl issue?

@dlakaplan
Copy link
Contributor Author

I think it would be nice to understand that issue, but I can't test it much more myself. I asked on slack if others could and also discussed at the cyber-I call.

@paulray paulray merged commit ce1dcec into nanograv:master Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve installation instructions
3 participants