Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting model.PARAM1 = model.PARAM2 no longer overrides the name of PARAM1 #1624

Merged
merged 5 commits into from
Aug 28, 2023

Conversation

dlakaplan
Copy link
Contributor

Fixes #1622 . Includes a test.

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (e73a86a) 68.25% compared to head (d852191) 68.26%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1624   +/-   ##
=======================================
  Coverage   68.25%   68.26%           
=======================================
  Files          99       99           
  Lines       22784    22789    +5     
  Branches     3916     3918    +2     
=======================================
+ Hits        15551    15556    +5     
  Misses       6273     6273           
  Partials      960      960           
Files Changed Coverage Δ
src/pint/models/timing_model.py 83.62% <100.00%> (+0.05%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abhisrkckl abhisrkckl merged commit 7943e1a into nanograv:master Aug 28, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assigning to a Parameter can override its name
3 participants