Radial velocities #1638
Radial velocities #1638
Conversation
Does it work for variations of these models like ell1h? |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1638 +/- ##
==========================================
+ Coverage 68.26% 68.29% +0.02%
==========================================
Files 100 100
Lines 23111 23119 +8
Branches 4010 4011 +1
==========================================
+ Hits 15777 15789 +12
+ Misses 6343 6341 -2
+ Partials 991 989 -2
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here. |
I haven't tried it yet - that's why this is still WIP. |
|
(also needs tests) |
|
I think this is probably ready, unless there are other tests. |
dlakaplan
added
the
awaiting review
src/pint/models/timing_model.py
Outdated
| Returns | ||
| ------- | ||
| array | ||
| The line-of-sight position |
There was a problem hiding this comment.
Can we explicitly say this position is with respect to the system barycenter (if that is indeed the case)?
src/pint/models/timing_model.py
Outdated
| Notes | ||
| ----- | ||
| This is the radial velocity of the pulsar. For the radial velocity of the companion, | ||
| this must be multiplied by -1 times the mass of the pulsar divided by the mass of the companion. |
There was a problem hiding this comment.
Why not just add companion_radial_velocity() that takes the mass ratio as an argument?
|
This is great! Thanks for adding it! |
|
Looks great! I'll 2nd Paul's thanks for doing this! |
#374
Works for DD, DDS, BT, ELL1, ELL1H models. Returns the RV of the pulsar or companion.