Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to python 3.12 for testing #1652

Merged
merged 9 commits into from
Oct 19, 2023
Merged

Conversation

dlakaplan
Copy link
Contributor

No description provided.

@dlakaplan dlakaplan linked an issue Oct 13, 2023 that may be closed by this pull request
@dlakaplan
Copy link
Contributor Author

https://docs.python.org/3/whatsnew/3.12.html
This means that distutils, setuptools, pkg_resources, and easy_install will no longer available by default; to access these run pip install setuptools in the [activated](https://docs.python.org/3/library/venv.html#venv-explanation) virtual environment.
so have to add these explicitly.

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (0201737) 68.33% compared to head (3cd2097) 68.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1652      +/-   ##
==========================================
+ Coverage   68.33%   68.35%   +0.01%     
==========================================
  Files         104      104              
  Lines       24112    24112              
  Branches     4280     4300      +20     
==========================================
+ Hits        16478    16482       +4     
+ Misses       6549     6548       -1     
+ Partials     1085     1082       -3     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dlakaplan
Copy link
Contributor Author

@paulray : this required a couple of tweaks because of how setuptools is now included. But I think it works. Should we change our default tests to use 3.12 or just keep it as a demo?

@paulray
Copy link
Member

paulray commented Oct 13, 2023

Well, we have oldestdeps on Python 3.8 and the oldest packages we support, so I think it makes sense to have the tests also run on the most recent versions to catch any compatibility issues that crop up. I'd go with 3.12 for our tests.

@dlakaplan dlakaplan added the awaiting review This PR needs someone to review it so it can be merged label Oct 17, 2023
@dlakaplan dlakaplan changed the title Try python 3.12 for testing Update to python 3.12 for testing Oct 17, 2023
@abhisrkckl
Copy link
Contributor

I'll merge this if ready.

@dlakaplan
Copy link
Contributor Author

I think so.

@abhisrkckl abhisrkckl merged commit 677e464 into nanograv:master Oct 19, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review This PR needs someone to review it so it can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update python used in testing?
3 participants