Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added elongation for pintk #1655

Merged
merged 2 commits into from
Oct 23, 2023
Merged

Conversation

dlakaplan
Copy link
Contributor

Screen Shot 2023-10-19 at 10 37 00 AM

@dlakaplan dlakaplan linked an issue Oct 19, 2023 that may be closed by this pull request
@dlakaplan dlakaplan added enhancement GUI awaiting review This PR needs someone to review it so it can be merged labels Oct 19, 2023
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (9b4739e) 68.50% compared to head (334fab7) 68.49%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1655      +/-   ##
==========================================
- Coverage   68.50%   68.49%   -0.01%     
==========================================
  Files         104      104              
  Lines       24264    24267       +3     
  Branches     4329     4330       +1     
==========================================
  Hits        16622    16622              
- Misses       6555     6558       +3     
  Partials     1087     1087              
Files Coverage Δ
src/pint/pintk/pulsar.py 33.43% <ø> (ø)
src/pint/pintk/plk.py 13.47% <0.00%> (-0.05%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abhisrkckl
Copy link
Contributor

What happens in the case of a timing model without an Astrometry component? (e.g. for already barycentered TOAs)

@dlakaplan
Copy link
Contributor Author

I think that is a separate issue. The buttons for e.g., orbital phase and frequency are present even for data that don't have a binary and don't have frequency info. Pressing those leads to non-fatal errors. Probably that should be fixed separately.

@abhisrkckl
Copy link
Contributor

I'll merge this if this is ready.

@dlakaplan
Copy link
Contributor Author

I think it's ready. I added #1658 to deal with the other cases you asked about

@abhisrkckl abhisrkckl merged commit a35fdfb into nanograv:master Oct 23, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review This PR needs someone to review it so it can be merged enhancement GUI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add solar elongation as an axis for PINTk
2 participants