-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up some tests #1657
Speed up some tests #1657
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1657 +/- ##
==========================================
+ Coverage 68.49% 68.51% +0.02%
==========================================
Files 104 104
Lines 24267 24264 -3
Branches 4330 4329 -1
==========================================
+ Hits 16622 16625 +3
+ Misses 6558 6553 -5
+ Partials 1087 1086 -1 ☔ View full report in Codecov by Sentry. |
Slowest 20 remaining tests:
|
Many of those are slow because they are going from tim files to toas and back for many permutations. Individual tests are fast but there are many of them. I'm wary of changing them, |
I think that this can still be worked on more generally, but as a minor PR this saves ~10 minutes from the CI testing and can probably be merged as-is. |
Trying to identify the tests that take the longest and make them faster. So far working on
test_grid.py
. Previously this took ~15min on my machine:but now it takes 5 (just made the grids smaller):