Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change_binary_epoch in TimingModel.compare() #1703

Merged
merged 7 commits into from
Dec 29, 2023

Conversation

abhisrkckl
Copy link
Contributor

No description provided.

@abhisrkckl abhisrkckl linked an issue Dec 26, 2023 that may be closed by this pull request
@abhisrkckl abhisrkckl changed the title WIP: change_binary_epoch in TimingModel.compare() change_binary_epoch in TimingModel.compare() Dec 26, 2023
Copy link

codecov bot commented Dec 26, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (4025e32) 68.76% compared to head (87c0e18) 68.76%.

Files Patch % Lines
src/pint/models/timing_model.py 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1703      +/-   ##
==========================================
- Coverage   68.76%   68.76%   -0.01%     
==========================================
  Files         105      105              
  Lines       24636    24642       +6     
  Branches     4404     4407       +3     
==========================================
+ Hits        16942    16946       +4     
- Misses       6589     6590       +1     
- Partials     1105     1106       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dlakaplan
Copy link
Contributor

Can merge when the conflict is resolved.

@dlakaplan
Copy link
Contributor

This looks fine. Let me know if you want me to merge.

@abhisrkckl
Copy link
Contributor Author

Yes. please merge this.

@dlakaplan dlakaplan merged commit 216e7e6 into nanograv:master Dec 29, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compare_models doesn't change_binary_epoch
2 participants