-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change_binary_epoch
in TimingModel.compare()
#1703
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhisrkckl
changed the title
WIP:
Dec 26, 2023
change_binary_epoch
in TimingModel.compare()
change_binary_epoch
in TimingModel.compare()
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1703 +/- ##
==========================================
- Coverage 68.76% 68.76% -0.01%
==========================================
Files 105 105
Lines 24636 24642 +6
Branches 4404 4407 +3
==========================================
+ Hits 16942 16946 +4
- Misses 6589 6590 +1
- Partials 1105 1106 +1 ☔ View full report in Codecov by Sentry. |
Can merge when the conflict is resolved. |
abhisrkckl
force-pushed
the
compare_models_binary
branch
from
December 28, 2023 15:47
6736508
to
5fdc27f
Compare
This looks fine. Let me know if you want me to merge. |
Yes. please merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.