Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multivariate-normal parameter bug #317

Merged
merged 5 commits into from
Mar 8, 2022
Merged

Conversation

vallis
Copy link
Collaborator

@vallis vallis commented Mar 4, 2022

Current code fails when specifying sigma as a matrix and size explicitly, due to a quirk in the numpy interface. Thanks to Aurelien Chalumeau for flagging this.

@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #317 (6eb2600) into master (dffb805) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #317      +/-   ##
==========================================
- Coverage   87.97%   87.94%   -0.04%     
==========================================
  Files          13       13              
  Lines        2978     2978              
==========================================
- Hits         2620     2619       -1     
- Misses        358      359       +1     
Impacted Files Coverage Δ
enterprise/signals/parameter.py 78.62% <100.00%> (ø)
enterprise/pulsar.py 92.21% <0.00%> (-0.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dffb805...6eb2600. Read the comment docs.

@vallis vallis merged commit 2df96c2 into nanograv:master Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant