Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix caching bug in signals.deterministic_signals.Deterministic #325

Merged
merged 6 commits into from
Nov 4, 2022
Merged

Fix caching bug in signals.deterministic_signals.Deterministic #325

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
71fdf52
Allow (re)setting Pulsar flags
vallis Sep 8, 2022
8ae3fc5
Modified definition of log10_dmequad in WidebandTimingModel (now matc…
Oct 27, 2022
4b1cbcc
Merge branch 'master' of https://github.com/vallis/enterprise
Oct 27, 2022
a81dfbb
Improve docstring.
Oct 27, 2022
ae35f14
Bugfix delay caching in deterministic_signals.py
vallis Nov 3, 2022
50a12b2
Merge branch 'master' of https://github.com/nanograv/enterprise
vallis Nov 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions enterprise/signals/deterministic_signals.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ def _do_selection(self, psr, waveform, selection):
sel = selection(psr)
self._keys = sorted(sel.masks.keys())
self._masks = [sel.masks[key] for key in self._keys]
self._delay = np.zeros(len(psr.toas))
self._ntoas = len(psr.toas)
self._wf, self._params = {}, {}
for key, mask in zip(self._keys, self._masks):
pnames = [psr.name, name, key]
Expand All @@ -45,9 +45,10 @@ def delay_params(self):
@signal_base.cache_call("delay_params")
def get_delay(self, params):
"""Return signal delay."""
delay = np.zeros(self._ntoas)
for key, mask in zip(self._keys, self._masks):
self._delay[mask] = self._wf[key](params=params, mask=mask)
return self._delay
delay[mask] = self._wf[key](params=params, mask=mask)
return delay

return Deterministic

Expand Down