-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Percentage Point Functions for parameters #353
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #353 +/- ##
==========================================
- Coverage 88.44% 87.48% -0.96%
==========================================
Files 13 13
Lines 3037 3133 +96
==========================================
+ Hits 2686 2741 +55
- Misses 351 392 +41
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
It seems that this requires some extra unit tests. Actually, the unit tests for the entire parameter class do not check for exceptions. I'll just update it to check for everything... |
@vhaasteren Is there anything that needs to be done on this one? |
No, is ready to go |
This PR adds the Percentage Point Function (PPF) to Enterprise parameters. The PPF is the inverse of the CDF, so it can be used to sample from the distribution. Some Nested Sampling implementations require the PPF as input: for instance MultiNest requires the "hypercube transformation". That is done with the PPF.
Now we can do something like:
The Truncated Normal PPF is not yet implemented, but
LinearExp
,Normal
, andUniform
are there.