Bugfix for bug #358 #359
Merged
Bugfix for bug #358 #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #359 +/- ##
=======================================
Coverage 88.37% 88.37%
=======================================
Files 13 13
Lines 3012 3012
=======================================
Hits 2662 2662
Misses 350 350
Continue to review full report in Codecov by Sentry.
|
…d to include cumbersome tests to not decrease coverage. Is never called anyway, and it doesn't slow things down.
Closed
AaronDJohnson
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes bug #358: when logdet=False, we still tried to unpack the return values of self.Nmat.solve