Adding Gibbs sampling code to ENTERPRISE EXTENSIONS (updated and fixed) #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Gibbs Method (Bayes Power) code for single pulsar analyses.
Testing the Gibbs Method code
The gibbs sampling code is added alongside its test. This method performs the Gibbs sampling of single-pulsar analyses.
Linting problems removed by "black". Altpol utils removed (they were included by accident!)
The updated Gibbs sampling code is added alongside its test. This method performs the Gibbs sampling of single-pulsar analyses.
|
It seems like "black" did not help with the linting issues. Is there a standard code formatting software that ENTERPRISE uses? |
|
Hi @NimaLaal, These are pep8 style issues pointed out by flake8. Here's how to fix it First
Also for |
The changes are made by autopep8
|
I will work on fixing the issues later today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The updated Gibbs sampling code is added alongside its test. This method performs a Gibbs sampling for single pulsars.
It was easier for me to close the other PR and open a new one. The linting issues should be solved now. I removed the altpol util functions as well (they were included by accident!)
I am getting used to the Github desktop app!