managers.py: issues with entry_id #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ates the string representation of the uuid, don't let Dataset.MultipleObjectsReturned error silently pass. tests.py: Removed 'entry_id' from predefined metadata dict and added test for a case when the metadata actually contains an entry_id.
|
@mortenwh , I generally agree with your edits. Did you test it? |
|
yes, it is tested - see |
|
I thought I could fix this in my own code - but it seems |
|
No.. |
mortenwh
added a commit
to mortenwh/nansat
that referenced
this pull request
Aug 14, 2020
akorosov
pushed a commit
to nansencenter/nansat
that referenced
this pull request
Aug 17, 2020
akorosov
approved these changes
Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See comments in the code for explanations.