Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce number of branches #200

Closed
akorosov opened this issue Dec 14, 2017 · 11 comments
Closed

Reduce number of branches #200

akorosov opened this issue Dec 14, 2017 · 11 comments

Comments

@akorosov
Copy link
Member

akorosov commented Dec 14, 2017

Problem There are too many branches. Some branches are wrongly branched from other issue branches, some are obsolete #### Solution Remove old branches

@akorosov akorosov added this to the Nansat 1.0 milestone Dec 14, 2017
@mortenwh
Copy link
Contributor

mortenwh commented Dec 14, 2017 via email

@aleksandervines
Copy link
Contributor

aleksandervines commented Jan 17, 2018

I suggest to remove:

  • the two branches for issue 54. issue 54 has been closed as "wontfix".
  • branches for issues 63/66/70/71/72/74/75/77/79/81/82/84/86/92/106/114/115/117/118/119/156/157 - issues have been closed and all commits merged into develop or master.
  • pythesint/add_mapper_tests - not sure what these branches are, but it does not contain anything not in master

@mortenwh
Copy link
Contributor

Points 1 and 2 ok with me. Is the last point about nansat? Can you add a link?

Apart from that, I am unsure about what to do with the branch issue113-get_transect-reverted-for-qp-paper - this is a version that was used for a paper which is now published. The last commit is 0f8ffa3 - as long as the hash code is (now) logged I guess the branch can be deleted, right?

@aleksandervines
Copy link
Contributor

aleksandervines commented Jan 17, 2018

point 3 is about 2 branches in nansat, one named pythesint and one named add_mapper_tests :) I can see the confusion in how I wrote it.

edit: and yes, seems to be safe to delete the issue113 branch you mentioned.

@aleksandervines
Copy link
Contributor

I further suggest to remove these branches, they are some commits ahead of master/develop, but that could be due to "wrong" git usage during the merge.

  • issue 60 branches, it is regarding issue 60 about online documentation, which is closed. It says it is 10 commits behind master, but this must be outdated (3-4 years old), we are currently updating the online documentation. Last commits in each branch 0ceacc6 fcbe0ea 23b6650
  • issue 76 branch. The issue is closed. I assume that any relevant stuff has been merged, and in either case last commit: db0f3c5
  • issue 99 brances. Issue closed and merged in bb9aa96 last commits: a37c8f6 7bd4e2f
  • issue 113 branch. Issue closed. last commit: 0f8ffa3
  • test-pyqt. Not directly connect to an issue. The only modification done in this is in the travis configuration, removing specific qt version pinning. This branch seems useless now, as I assume the only use of it was to see how travis behaved.

@akorosov
Copy link
Member Author

All of these branches can be deleted. Thanks, @alevin!

@aleksandervines
Copy link
Contributor

Everything above is deleted.

Comments on remaining stale branches:

@akorosov
Copy link
Member Author

  • issue91-nansattest - is outdated and can be deleted.
  • issue123-fillValue - I agree with @aleksandervines
  • issue39-SARcomplexdata - is outdated and can be deleted.
  • issue98-legendImage - I agree with @aleksandervines
  • issue98-legendImage-develop - has wrong implementation. Can be deleted.
  • issue58-update - I agree with @aleksandervines
  • issue58-update-develop - is outdated and can be deleted.
  • issue42 - is outdated and can be deleted.

@aleksandervines
Copy link
Contributor

Will delete them.
Last one, @mortenwh - dev_doppler_vm ?

@mortenwh
Copy link
Contributor

I have now deleted the branch dev_doppler_vm

@aleksandervines
Copy link
Contributor

Everything should now be cleaned up. It should be no need to merge any branches, as previously suggested.

For reference for #42 this is the last commit in the deleted issue42 branch. 2749467

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants