Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor openwind and make it compatible with Python 3 and Nansat v1.1 #30

Open
2 of 7 tasks
mortenwh opened this issue Feb 1, 2018 · 5 comments
Open
2 of 7 tasks
Assignees

Comments

@mortenwh
Copy link
Contributor

mortenwh commented Feb 1, 2018

Challenges:

  • we operate on potentially three Nansat objects:
    1. A model wind field, e.g., NCEP
    2. A SAR NRCS image
    3. A SAR Doppler image
  • optionally, two Nansat objects plus a constant (or a numpy array of) wind direction(s)
  • In addition to this, we should consider adding other data as well, e.g., from scatterometers..
    • OpenWind only makes calculations
    • OpenWind class takes only arrays as input
    • OpenWind class needs to be able to apply an unlimited amount of wind datasets/arrays
    • Generate new Nansat object after processing
    • Writes to file
  • Importer class (does not need to inherit from Nansat but needs to handle domains)
    • from_nansat (uses Nansat, including reprojection handling(?))
    • from_float
    • from_string
    • etc.
  • Exporter class
    • e.g., to store only wind field

TODO's:

  • Add vagrantfile to openwind repos(?)

  • Define the user interface: initialization with NRCS image file or initialization with all datasets (as presently)?

  • Create a new core class (OpenWind) to which we connect Nansat, various algorithms and the user interface (SARWind)

  • Add notes and comments in SARWind to follow up with a discussion of todo's

  • Refactor SARWind

  • Create unit tests

  • check how this todo list works

@mortenwh mortenwh self-assigned this Feb 6, 2018
korvinos added a commit that referenced this issue Feb 7, 2018
korvinos added a commit that referenced this issue Feb 7, 2018
korvinos added a commit that referenced this issue Feb 7, 2018
korvinos added a commit that referenced this issue Feb 7, 2018
korvinos added a commit that referenced this issue Feb 7, 2018
@mortenwh
Copy link
Contributor Author

mortenwh commented Feb 7, 2018

obs - we have both created branches for this issue....

@korvinos
Copy link
Member

korvinos commented Feb 7, 2018

Yes, which one will we use?

@mortenwh
Copy link
Contributor Author

mortenwh commented Feb 7, 2018

We can use yours. Can you merge with mine and delete my branch?

@korvinos
Copy link
Member

korvinos commented Feb 7, 2018

Yes, sure

korvinos added a commit that referenced this issue Feb 7, 2018
@korvinos
Copy link
Member

korvinos commented Feb 7, 2018

@mortenwh Done

mortenwh added a commit that referenced this issue Jun 24, 2019
mortenwh added a commit that referenced this issue Jun 25, 2019
…olete code and added more provisioning configs.
mortenwh added a commit that referenced this issue Jul 4, 2019
mortenwh added a commit that referenced this issue Jul 4, 2019
mortenwh added a commit that referenced this issue Jul 4, 2019
mortenwh added a commit that referenced this issue Jul 4, 2019
mortenwh added a commit that referenced this issue Jul 5, 2019
mortenwh added a commit that referenced this issue Jul 5, 2019
mortenwh added a commit that referenced this issue Jul 9, 2019
mortenwh added a commit that referenced this issue Jul 10, 2019
mortenwh added a commit that referenced this issue Jul 10, 2019
… plus some changes in sentinel-1 wind notebook
mortenwh added a commit that referenced this issue Jul 10, 2019
mortenwh added a commit that referenced this issue Jul 10, 2019
mortenwh added a commit that referenced this issue Jul 10, 2019
mortenwh added a commit that referenced this issue Jul 11, 2019
mortenwh added a commit that referenced this issue Jul 11, 2019
mortenwh added a commit that referenced this issue Jul 11, 2019
…y storage should not be necessary now, but can be removed later.
mortenwh added a commit that referenced this issue Aug 28, 2019
… directly in the PRODUCT_FOLDER root. Generalised insertion of data_center and naming_authority metadata
mortenwh added a commit to mortenwh/openwind that referenced this issue Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants