Handle filter window reaching end of source #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the rank filter relied on not explicitly supported behavior of libstdc++ and libc++, which was not guaranteed in the C++ standard. Namely that a negative index could be permissible and could retrieve values that had already been popped from the deque. However this isn't a good thing to rely on given the C++ standard does not provide for this. Further some C++ libraries like VC++ actually don't support this behavior and error instead. To fix this issue, we explicitly store the previously stored value dropped from the window into the next value for this case. This explicitly provides the same behavior that libstdc++ and libc++, but without relying on undefined behavior of deque. Thus this should work well with VC++ and generally be a more robust strategy for handling this case going forward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the rank filter relied on not explicitly supported behavior of libstdc++ and libc++, which was not guaranteed in the C++ standard. Namely that a negative index could be permissible and could retrieve values that had already been popped from the deque. However this isn't a good thing to rely on given the C++ standard does not provide for this. Further some C++ libraries like VC++ actually don't support this behavior and error instead.
To fix this issue, we explicitly store the previously stored value dropped from the window into the next value for this case. This explicitly provides the same behavior that libstdc++ and libc++, but without relying on undefined behavior of deque. Thus this should work well with VC++ and generally be a more robust strategy for handling this case going forward.