Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix-up some errors #140

Merged
merged 4 commits into from
Oct 16, 2018
Merged

Fix-up some errors #140

merged 4 commits into from
Oct 16, 2018

Conversation

jakirkham
Copy link
Member

Convert some asserts to raises. Use ValueError in all cases of bad values (even when axis is out of bounds).

@jakirkham jakirkham merged commit 6d36ac1 into nanshe-org:master Oct 16, 2018
@jakirkham jakirkham deleted the conv_assert_to_errs branch October 16, 2018 13:03
@jakirkham jakirkham mentioned this pull request Oct 16, 2018
Merged
@jakirkham
Copy link
Member Author

Fixed a few more in PR ( #145 ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jakirkham