Use prefix operators for increment/decrement #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prefix incrementing and decrementing don't incur a copying overhead to keep the previous iterator around. So it is preferable to use prefix operations when possible.
As `rank_point` is an iterator, it is preferable to use prefix operations with it to avoid copying overhead associated with the postfix operations. Hence this makes that change.
While these are all integers and are cheap (or free) to use with postfix operators, prefer using prefix operators to match with general style.
jakirkham
force-pushed
the
use_prefix_inc_dec
branch
from
bc5266d
to
64b95e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For cases where iterators are in use, it's better to use prefix increment/decrement so the operation can happen in-place without making a copy of the iterator. Follow-up on a few other cases for style.