Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 159 #161

Merged
merged 2 commits into from
Apr 23, 2021
Merged

Issue 159 #161

merged 2 commits into from
Apr 23, 2021

Conversation

naomijub
Copy link
Owner

@naomijub naomijub commented Apr 16, 2021

This is the issue of using too much space for caching. There were 2 solutions being explored:

  1. Remove state caching and do all IOs for select queries (this increase time to query by ~30%)
  2. Keep it as is having a giant heap memory consumption and giant file being written.

The solutions was neither...
Now the state is being converted to Vec<u8> and the file size reduced to half and the memory consumption to 35%.
994504 bytes - 2021_04_16.log
401719 bytes - local_data.log file containing all the caching info (it was larger than 2021_04_16.log before.

Performance decrease can be found in benchmark file diff

Related to issue #159

@naomijub naomijub merged commit d8b7d9f into main Apr 23, 2021
@naomijub naomijub deleted the issue-159 branch April 23, 2021 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant