Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS Only] Support Passcode Fallback Natively #101

Merged
merged 9 commits into from
Oct 27, 2018
Merged

Conversation

ianoshorty
Copy link
Contributor

This change simply allows iOS to use Passcode fallback if its available and needed. It does not change the behaviour of FaceID / TouchID in any other way, and only uses Passcode as a fallback. Some extended discussion is at #34 - which notes you may wish to enable a switch to enable / disable this - but this PR is enough for us.

Happy for it to be merged if you like.

@EyMaddis
Copy link

bump @naoufal

@zibs
Copy link
Collaborator

zibs commented May 26, 2018

@naoufal This works and looks good to me. I'm okay with the native fallback, we should just add something to the readme since this might change existing user's expectations.

@wanschi
Copy link

wanschi commented Jun 26, 2018

Is there a reason why this is not merged?

@ianoshorty
Copy link
Contributor Author

I've updated this PR to merge all recent changes and still support fallback to passcode auth. If this isn't merged in a few weeks, I will close the PR as I'm guessing it isn't needed.

@zibs
Copy link
Collaborator

zibs commented Oct 2, 2018

Hey, thanks for the PR @ianoshorty - I'll give it a run through this week to make sure everything checks out. Let's add that optional config option to enable this feature though, since we don't want to change existing functionality. Do you mind doing that? if not, feel free to allow edits from maintainers from this PR and I'll go in an add it.

@ianoshorty
Copy link
Contributor Author

I wont be able to further update the PR till next week. I'd be happy to take a look then though to add the config option if its needed.

@ianoshorty
Copy link
Contributor Author

@zibs As requested, I've added a config option passcodeFallback, default false, which when true will utilise keypad based passcode entry. This is documented in the readme.

Hope thats everything!

@anandwahed
Copy link

@zibs any idea when this will be merged in master ?

@zibs
Copy link
Collaborator

zibs commented Oct 23, 2018

Thanks for the bump! I just need to test it and make sure it's good to go and then will merge and release asap. I can try my darn'dest to get to on the weekend if not sooner.

@zibs
Copy link
Collaborator

zibs commented Oct 27, 2018

Works! Thanks! I'm going to bump the version to 4.2.

@randomor
Copy link

Is this system passcode fallback still being presented? I'm not seeing anything on iPhone X and only saw an error in the catch callback... Would appreciate some pointers on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants