Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build.gradle #219

Merged
merged 1 commit into from
May 31, 2019
Merged

Update build.gradle #219

merged 1 commit into from
May 31, 2019

Conversation

SaeedZhiany
Copy link
Contributor

read android gradle plugin version from user project

read android gradle plugin version from user project
@zibs zibs merged commit d7b69c6 into naoufal:master May 31, 2019
@SaeedZhiany
Copy link
Contributor Author

Who have tested this commit? It breaks android build

@Dimon70007
My bad and I'm sorry. are you familiar with gradle build system? if yes, can you help me to make it works? I think it's a good idea if we can read gradle plugin version from the user project, just like the other options (e.g. compileSdkVersion). I already open an issue on react-native repository for this.

Can you post what's the error message you get on building android?

if no @zibs please revert my changes on this PR.

@Dimon70007
Copy link

I get error when run any gradle task:

ERROR: Could not get unknown property '_ext' for object of type org.gradle.api.internal.artifacts.dsl.dependencies.DefaultDependencyHandler.

@Dimon70007
Copy link

Dimon70007 commented Jul 2, 2019

@SaeedZhiany, I am not sure, but you can try something like this - https://gist.github.com/Dimon70007/238a7a0371183c6ed4bea8a97bef6437

@SaeedZhiany
Copy link
Contributor Author

@SaeedZhiany, I am not sure, but you can try something like this - https://gist.github.com/Dimon70007/238a7a0371183c6ed4bea8a97bef6437

have you tested this yourself?

@Dimon70007
Copy link

Dimon70007 commented Jul 3, 2019

have you tested this yourself?

This build.gradle does not crash the build, but i did not tested it for what version it uses if i specify buildGradlePluginVersion in the rooProject

@arlovip
Copy link

arlovip commented Nov 5, 2019

I get error when run any gradle task:

ERROR: Could not get unknown property '_ext' for object of type org.gradle.api.internal.artifacts.dsl.dependencies.DefaultDependencyHandler.

Today I got the same error with react-native run-android

FAILURE: Build failed with an exception.

* Where:
Build file '/Users/langke/Developer/JTool/node_modules/react-native-touch-id/android/build.gradle' line: 17

* What went wrong:
A problem occurred evaluating project ':react-native-touch-id'.
> Could not get unknown property '_ext' for object of type org.gradle.api.internal.artifacts.dsl.dependencies.DefaultDependencyHandler.

@SaeedZhiany
Copy link
Contributor Author

SaeedZhiany commented Nov 5, 2019

Sorry about the build failure, I currently submit another PR here to fix the problem, @zibs please review that PR. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants