Update where app-model actions/providers/processors live in codebase #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
DragaDoncila
reviewed
May 3, 2024
| of living in a menu and are thus considered 'Qt' actions. | ||
| This also ensures that there is only one file defining. | ||
|
|
||
| The layer context menu actions do not require a GUI and thus live in |
There was a problem hiding this comment.
Suggested change
| The layer context menu actions do not require a GUI and thus live in | |
| The layer context menu actions do not require a GUI (they only require the `layerlist`) and thus live in |
|
Thanks, changes made! |
DragaDoncila
approved these changes
May 3, 2024
|
AH whoops sorry, I forgot this has already been approved. I realise that we now no longer have qt providers or processors anymore, so I've updated that here too. Sorry! |
lucyleeow
changed the title
napari codebase napari codebase
lucyleeow
changed the title
napari codebase 
|
@lucyleeow do we now have to wait for #6743 to go in before we merge this? |
|
🤦 yes you are right. I'll add a depends on |
|
test comment |
|
The depends on has now been merged (not sure why the CI is still failing) so maybe this could go in now, @DragaDoncila ? |
|
thanks @lucyleeow sorry for the delay... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References and relevant issues
Relates to napari/napari#6848
Depends on napari/napari#6743
Description
Updates the info on where actions live in the napari codebase.