Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Add note on string type annotations in widget contributions #345

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

lucyleeow
Copy link
Contributor

Add note that type annotations should be str to avoid having napari as dependency

@lucyleeow lucyleeow changed the title Doc Add note on string type annotations in widget contributions DOC Add note on string type annotations in widget contributions Apr 3, 2024
@lucyleeow
Copy link
Contributor Author

cc @DragaDoncila

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (595b088) to head (8909ae1).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #345   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           37        37           
  Lines         2750      2750           
=========================================
  Hits          2750      2750           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@DragaDoncila DragaDoncila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member

@psobolewskiPhD psobolewskiPhD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DragaDoncila DragaDoncila merged commit 2622e1c into napari:main Apr 5, 2024
32 checks passed
@lucyleeow lucyleeow deleted the doc_types branch April 5, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants