Update UI and connect to constructor manager API #63

goanpeca · 2023-01-26T21:03:32Z

Overview

## Constructor based installers

These installers will contain 3 main environments when created:

A base environment which will contain:
- conda (package and environment manager)
- mamba (conda "replacement" for performing faster solves, transactions and downloads)
- conda-lock (create locked and reproducible environments)
A constructor-manager environment which will contain:
- constructor-manager
- constructor-manager-api (Add constructor manager api #46)
- constructor-manager-ui (Update UI and connect to constructor manager API #63)
An application environment, using the conventions <package-name>-<version>, for the example image above, napari-0.4.15

More information on packaging on https://napari.org/dev/developers/packaging.html#constructor-based-installers

constructor-manager-ui

This pull request is in charge of connecting the previously created UI (#40) the constructor-manager-ui package which in its present form is a pyqt/pyside based application. It provides a graphical interface to run the different actions to manage an application built with constructor

The ui is called from the command line interface with constructor-manager-ui <package-name>. Since the application will be called using standard application calls created by menuinst, arguments will be passed with configuration files handled by constructor-manager-client calls.

check-updates: Query for new updates available for the managed application by providing one or more anaconda.org channels. By default we query the conda-forge channel located at https://anaconda.org/conda-forge/
update: update a current application to a new version of it. This process will create a new conda environment following the convention <package-name>-<new-version>, create new menu shortcuts (using the menuinst branch https://github.com/conda/menuinst/tree/cep-devel/menuinst), create a new restore point (using conda-lock), remove the old environment and the corresponding shortcuts for the old versions of the managed application.
revert: this will revert the current application to the previously installed version on the computer if a restore point is found. This will follow a similar process of creating a new conda environment with the convention <package-name>-<old-version>.
restore: similar to revert but restore to a previously found state of the current version. This command could become a single one by providing the specific restore file (which is created by conda lock)
open: open the managed give application.

Work in progress

Handle settings
Release package to pypi
Release package to conda-forge
Tests (just some small ones to check basic functionality is in place)

Future work

Add better status handling
Add uninstall management

goanpeca · 2023-03-15T13:14:35Z

Fixing the tests, but this one is ready for review @aganders3, @dalthviz, @potating-potato

(Also need to complete docstrings)

Thanks!

dalthviz

Hi @goanpeca ! Left some comments/questions regarding commented out code, some qss styles, some print statements, the CI workflow reorganization and a traceback related with the log level setting that appeared when I was trying to run some commands

dalthviz · 2023-03-15T15:24:41Z

constructor-manager-ui/src/constructor_manager_ui/main.py


-        return install_information_group
+    log_level = getattr(logging, log_level.upper())


Tried running constructor-manager-ui napari --current-version 0.4.16 --build-string pyside --plugins-url https://api.napari-hub.org/plugins --channel conda-forge locally and got the following traceback related to this line:

Traceback (most recent call last): File "C:\Users\dalth\anaconda3\envs\constructor-manager\lib\runpy.py", line 196, in _run_module_as_main return _run_code(code, main_globals, None, File "C:\Users\dalth\anaconda3\envs\constructor-manager\lib\runpy.py", line 86, in _run_code exec(code, run_globals) File "C:\Users\dalth\anaconda3\envs\constructor-manager\Scripts\constructor-manager-ui.exe\__main__.py", line 7, in <module> File "E:\Acer\Documentos\Quansight\Napari\packaging\constructor-manager-ui\src\constructor_manager_ui\main.py", line 58, in run _configure_logging(settings["log"]) File "E:\Acer\Documentos\Quansight\Napari\packaging\constructor-manager-ui\src\constructor_manager_ui\main.py", line 33, in _configure_logging log_level = getattr(logging, log_level.upper()) AttributeError: 'NoneType' object has no attribute 'upper'

This is part of the issue of calling on windows. Fixing over the CLI PR

dalthviz · 2023-03-15T15:28:03Z

constructor-manager-ui/src/constructor_manager_ui/style/base.qss

+  background-color: @background-color13;
+  background-color: @background-selection-color01;
+  background-color: #758193;


Should here be only the entry for #758193 while also making it part of the colors constants available?

Yes, we can do that

dalthviz · 2023-03-15T15:30:28Z

constructor-manager-ui/src/constructor_manager_ui/widgets/dialog.py

+        # f"Last modified {self.current_version['last_modified']}"
+        # )


I guess this is part of a TODO (as well as the commented text for labels code bellow), right?

dalthviz · 2023-03-15T15:36:18Z

constructor-manager-ui/src/constructor_manager_ui/widgets/dialog.py

+        # Installation Actions
+        feedback_group = self._create_feedback_group()
+        main_layout.addWidget(feedback_group, stretch=1)
+        print(self.log)


Should this and other print statements in the file be transformed into logger.info/logger.debug calls?

Yes absolutely

dalthviz · 2023-03-15T15:37:09Z

constructor-manager-ui/src/constructor_manager_ui/widgets/dialog.py

+        # while ConstructorManagerWorker._WORKERS:
+        #     worker = ConstructorManagerWorker._WORKERS.pop()
+        #     self._terminate_worker(worker)


Should this be removed or uncommented?

Removed, we do not want to force close in the middle of an update.

dalthviz · 2023-03-15T15:42:10Z

.github/workflows/tests.yml

+      - name: Test constructor-manager-ui (linux)
+        if: contains(matrix.platform, 'ubuntu')
+        run: |
+          # Run Tests
+          cd constructor-manager-ui/src
+          xvfb-run pytest constructor_manager_ui --cov=constructor_manager_ui
+
+      - name: Test constructor-manager-ui (other)
+        if: "!contains(matrix.platform, 'ubuntu')"
+        run: |
+          # Run Tests
+          cd constructor-manager-ui/src
+          pytest constructor_manager_ui --cov=constructor_manager_ui


I guess the UI part will not use tox for the tests on the CI? Should the tox.ini file be removed?

Yes, since all the workflow for these packages revolves around constructor using a base environment and a constructor-manager environment, tox does not help a lot. Will remove!

DragaDoncila · 2023-04-12T02:36:04Z

Hi @goanpeca I'm curious whether you have examples of built napari applications that work with this PR, #34 and #46? Essentially it would be great to have a bundle we can download and play with that makes use of this Constructor Manager.

Otherwise as I understand it each piece can be played with individually either from the command line or by following the instructions in the PR description?

goanpeca · 2023-04-12T16:29:55Z

Hi @DragaDoncila, I will update a small snippet to install all the needed deps (including installing from these PRs) so you can test the whole workflow. Thanks!

Update CLI to take generic parameters and connect to API

1ed40b2

goanpeca changed the title ~~Update CLI to take generic parameters and connect to API~~ Update UI and connect to constructor manager API Jan 26, 2023

Split the code in widgets and main and add logging

98ce016

This was referenced Feb 15, 2023

Add constructor manager cli #34

Open

Add constructor manager api #46

Open

goanpeca added 4 commits March 7, 2023 19:20

Update imports

4610393

Split widget modules

3fe548a

Update widget files

a78cd04

Update readme fix testing

0097100

goanpeca force-pushed the update-ui-connect-api branch from b36d81c to 0097100 Compare March 14, 2023 18:15

goanpeca self-assigned this Mar 15, 2023

goanpeca requested review from dalthviz and liu-ziyang March 15, 2023 13:11

goanpeca marked this pull request as ready for review March 15, 2023 13:46

dalthviz reviewed Mar 15, 2023

View reviewed changes

dalthviz mentioned this pull request Jun 26, 2024

Application manager: Decouple from napari #154

Open

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update UI and connect to constructor manager API #63

Update UI and connect to constructor manager API #63

goanpeca commented Jan 26, 2023 •

edited

Loading

goanpeca commented Mar 15, 2023 •

edited

Loading

dalthviz left a comment •

edited

Loading

dalthviz Mar 15, 2023

goanpeca May 31, 2023

dalthviz Mar 15, 2023

goanpeca May 31, 2023

dalthviz Mar 15, 2023

goanpeca May 31, 2023

dalthviz Mar 15, 2023

goanpeca May 31, 2023

dalthviz Mar 15, 2023

goanpeca May 31, 2023

dalthviz Mar 15, 2023

goanpeca Mar 15, 2023

DragaDoncila commented Apr 12, 2023

goanpeca commented Apr 12, 2023


		return install_information_group
		log_level = getattr(logging, log_level.upper())

		# f"Last modified {self.current_version['last_modified']}"
		# )

Update UI and connect to constructor manager API #63

Are you sure you want to change the base?

Update UI and connect to constructor manager API #63

Conversation

goanpeca commented Jan 26, 2023 • edited Loading

Overview

constructor-manager-ui

Work in progress

Future work

goanpeca commented Mar 15, 2023 • edited Loading

dalthviz left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DragaDoncila commented Apr 12, 2023

goanpeca commented Apr 12, 2023

goanpeca commented Jan 26, 2023 •

edited

Loading

goanpeca commented Mar 15, 2023 •

edited

Loading

dalthviz left a comment •

edited

Loading