Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples related to bbox #878

Closed
wants to merge 4 commits into from
Closed

Add examples related to bbox #878

wants to merge 4 commits into from

Conversation

Kishlay-notabot
Copy link
Contributor

In order to compensate for the absence of the examples related to bbox and its functions, I've added the above files for people to explore and tweak. The inspiration came from the official site's demo.

@Kishlay-notabot
Copy link
Contributor Author

@Balearica Please approve if found apt.

@Balearica
Copy link
Member

It looks like this is a functional example showing how to retrieve bounding box information, which I agree other users may find helpful.

In general, my concern regarding adding new examples to the main Tesseract.js repo is that users assume that everything here is up to date, so whenever a new example gets added, I am effectively committing to maintaining it going forward. This is why all of the examples that currently exist in the examples directory are extremely minimal and only demonstrate core concepts.

When users create examples that are larger in terms of lines of code, or demonstrate a more niche use, we generally keep those in separate repos that are linked in this section of the Tesseract.js readme. Therefore, if you want to move this example to its own repo, and document what it does and how to run it in the readme, we can link in the Tesseract.js readme.

@Kishlay-notabot
Copy link
Contributor Author

Oh thanks, I'll make a seperate repo for the examples then, no issues.

@Kishlay-notabot
Copy link
Contributor Author

Kishlay-notabot commented Feb 8, 2024

@Balearica when i add the new repo with a pull request i suggest we should add a markdown notification in the examples folder directing the users to more of the complex examples mentioned in the main readme but sometimes people jump directly to examples and don't find what they need. I'll work on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants