Guard site submission concurrency #181
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narc0tiq
commented
Oct 30, 2024
| @@ -1512,7 +1514,7 @@ function resmon.on_click.expand_site(event) | |||
| site cleans up the expansion-related variables on the site) or if we were adding a new site | |||
| and decide to expand an existing one | |||
| --]] | |||
| if are_we_cancelling_expand or player_data.current_site then | |||
| if are_we_cancelling_expand and player_data.current_site then | |||
There was a problem hiding this comment.
Honestly, I suspect just patching this one would fix the actual issue but it's safer for submit_site to actually check its input before it works on it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible for the game to attempt to submit "the current site" when there is no current site (see #143 for an example) so just make sure that
submit_sitedoesn't try to do anything if there is no current site.Fixes #143