added english to hebrew error messages (#23) #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 3, 2016 05:58
I think error messages should have english text with the local text so all that see it in error reports can understand what the error is... This specific PR has lines 80 and above fixed to include english with hebrew
I can update #23 when I publish new strings, as I've done in the past. If you're subscribed to that issue, you should get an email from github about it when I do. |
narc0tiq
added a commit
that referenced
this pull request
Jul 1, 2016
Yes, I've made sure I am, thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
can wait for next version because I uploaded the file to the forum post, but please give me time to add strings, if there will be more next version - is there a way to know in advance when you change the strings file ?)