Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New action to reload an individual view and all of its children #7343

Closed
akhenry opened this issue Jan 7, 2024 · 3 comments · Fixed by #7362
Closed

New action to reload an individual view and all of its children #7343

akhenry opened this issue Jan 7, 2024 · 3 comments · Fixed by #7362
Labels
type:feature Feature. Required intentional design verified Tested or intentionally closed
Milestone
Target:4.0.0

Comments

@akhenry
Copy link
Contributor

akhenry commented Jan 7, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.
There are situations where it is useful to be able to reload the telemetry in an individual view either because it's embedded within a complex layout, or simply to avoid incurring the cost of a browser refresh. An example of this case is when telemetry throttling results in telemetry being dropped. It may be possible to recover the dropped telemetry by re-requesting historical data.

Describe the solution you'd like
A new action in a view's menu that triggers an individual view to be reloaded.

Ideally we would more selectively reload just the telemetry such that we do not lose any ephemeral configuration that the user has defined. This is significantly more work though, and requires new API, modifications to all existing screens, and imposes a new requirement on developers to support it.
@scottbell scottbell self-assigned this Jan 8, 2024
@scottbell scottbell mentioned this issue Jan 9, 2024
Merged
15 tasks
@scottbell scottbell linked a pull request Jan 9, 2024 that will close this issue
New action to reload an individual view and all of its children #7362
Merged
15 tasks
@scottbell
Copy link
Contributor

scottbell commented Jan 9, 2024 •
edited
Loading

To test:

  1. Create two Sinewave generators
  2. Create a Display Layout
  3. Drop both Sinewave generators onto the layout
  4. Click the Action toolbar (hamburger menu) and select "Reload" on the Display Layout
  5. Ensure both Sinewave generators reload
  6. Do the same for the individual Sinewave generators
  7. Test a smattering of other object views too (e.g., Gauges)

@unlikelyzero unlikelyzero added type:feature Feature. Required intentional design and removed type:enhancement labels Jan 9, 2024
@unlikelyzero unlikelyzero added this to the Target:3.3.0 milestone Jan 9, 2024
@scottbell scottbell mentioned this issue Jan 11, 2024
Open
@unlikelyzero unlikelyzero modified the milestones: Target:3.3.0, Target:4.0.0 Jan 17, 2024
@khalidadil
Copy link
Contributor

khalidadil commented Jan 25, 2024 •
edited
Loading

Verified in Testathon on 01/25/23 (tested using SWG alphanumerics, a notebook, a telemetry table, and a gauge)

@rukmini-bose
Copy link
Contributor

Verified Testathon 1/25/24

@unlikelyzero unlikelyzero added the verified Tested or intentionally closed label Jan 25, 2024
charlesh88 added a commit that referenced this issue Mar 1, 2024
@charlesh88
Closes #7343
843e553 
- Fixed an oversight that caused the top of form dialogs to
be scrolled out of view by default.
- Fixed approach to vertical centering for `-fit` type confirmation dialogs.
- Reduced size of confirmation dialog icons.
- Smoke tested in Chrome mobile emulator in a large variety of mobile
viewport sizes and orientations.
charlesh88 added a commit that referenced this issue Mar 1, 2024
@charlesh88
Closes #7343
6a6538d 
- Removes extra margin unintentionally added to `l-overlay-large`.
unlikelyzero added a commit that referenced this issue Mar 3, 2024
@rukmini-bose @unlikelyzero @charlesh88
[Mobile] Center Confirmation Dialog Texts (#7492)
73eead6 
* Make overlay messages centered

* Fix changes so that only dialogs and not forms are affected

* Fix buttons such that they are right-aligned

* Reduce to one worker for stability

* Add test to cover new capabilities

* lint fixes

* Closes #7343
- Fixed an oversight that caused the top of form dialogs to
be scrolled out of view by default.
- Fixed approach to vertical centering for `-fit` type confirmation dialogs.
- Reduced size of confirmation dialog icons.
- Smoke tested in Chrome mobile emulator in a large variety of mobile
viewport sizes and orientations.

* Closes #7343
- Removes extra margin unintentionally added to `l-overlay-large`.

---------

Co-authored-by: John Hill <[email protected]>
Co-authored-by: Charles Hacskaylo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:feature Feature. Required intentional design verified Tested or intentionally closed
Projects
None yet
Milestone
Target:4.0.0
Development

Successfully merging a pull request may close this issue.

New action to reload an individual view and all of its children nasa/openmct
5 participants
@khalidadil @akhenry @scottbell @unlikelyzero @rukmini-bose