Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event colors don't provide enough contrast #7410

Closed
charlesh88 opened this issue Jan 24, 2024 · 3 comments
Closed

Event colors don't provide enough contrast #7410

charlesh88 opened this issue Jan 24, 2024 · 3 comments
Assignees
Labels
Milestone

Comments

@charlesh88
Copy link
Contributor

charlesh88 commented Jan 24, 2024

As reported by VIPER, there are issues with colors used for text in the Events table, particularly for Errors which use a red color. These colors are defined in SCSS files in the open repo, hence this issue. This is a problem for mission-critical information, so this is a blocker.

Colors should be adjusted in all themes and smoke tested for a11y conformance.

@charlesh88
Copy link
Contributor Author

Testing Notes

Reference images show examples of all the different event color levels (yellow, red, purple, orange) in Espresso and Snow themes.

  1. View Events data in a way that allows you to see all the available levels of events in your deployment.
  2. Verify that the table's view corresponds with the matching theme reference image below.
  3. If you have the Wave accessibility plugin installed, enable that and verify that there are no Contrast violations in the table's view area. IMPORTANT: this issue depends on certain key theme colors (like the page body background color) having been updated via Fix constrast for accessibility #7315. If those changes aren't merged, then this step won't pass verification.
  4. Switch themes using the devtools Console command openmct.install(openmct.plugins.Snow()) or openmct.install(openmct.plugins.Espresso()).
  5. Repeat steps 2 and 3.

Espresso theme example

Screenshot 2024-01-24 at 3 15 50 PM

Snow theme example

Screenshot 2024-01-24 at 3 17 01 PM

charlesh88 added a commit that referenced this issue Jan 24, 2024
- Event display approach modified to include background color.
- Theme colors modified and constrast verified via Wave a11y browser plugin.
charlesh88 added a commit that referenced this issue Jan 25, 2024
- CHERRY PICK FROM event-colors-7410.
- Event display approach modified to include background color.
- Theme colors modified and constrast verified via Wave a11y browser plugin.
@unlikelyzero unlikelyzero added this to the Target:4.0.0 milestone Feb 1, 2024
@rukmini-bose
Copy link
Contributor

Verified Testathon 2/5/2024. Looks gucci

@ozyx
Copy link
Contributor

ozyx commented Feb 5, 2024

Verified Testathon 2/5/2024

@ozyx ozyx added the verified Tested or intentionally closed label Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants