Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open in new tab has stopped working. #7524

Closed
2 of 7 tasks
akhenry opened this issue Feb 27, 2024 · 3 comments · Fixed by #7542
Closed
2 of 7 tasks

Open in new tab has stopped working. #7524

akhenry opened this issue Feb 27, 2024 · 3 comments · Fixed by #7542
Assignees
@ozyx
Labels
severity:critical type:bug verified Tested or intentionally closed
Milestone
Target:4.0.0

Comments

@akhenry
Copy link
Contributor

akhenry commented Feb 27, 2024 •
edited by ozyx
Loading

Summary

The "open in new tab" action from the context menu in display layouts has stopped working for some reason. It shows an error in the JavaScript console

Steps to Reproduce

  1. Open (or create) a display layout containing a LAD table
  2. Click on the context menu (three-dot menu) in the LAD table and select "Open In New Tab"
  3. Observe that nothing happens and there is an error in the console

Environment

  • Open MCT Version: 5f8d689
  • Deployment Type: testathon

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information

Uncaught TypeError: Cannot convert object to primitive value
    at paramsToArray (url.js:51:29)
    at objectPathToUrl (url.js:72:1)
    at OpenInNewTab.invoke (openInNewTabAction.js:35:30)
    at action.onItemClicked (MenuAPI.js:81:1)
    at callWithErrorHandling (runtime-core.esm-bundler.js:192:1)
    at callWithAsyncErrorHandling (runtime-core.esm-bundler.js:199:1)
    at HTMLLIElement.invoker (runtime-dom.esm-bundler.js:681:31)
    ```
@ozyx ozyx added this to the Target:4.0.0 milestone Feb 27, 2024
@ozyx ozyx self-assigned this Mar 1, 2024
@ozyx ozyx mentioned this issue Mar 3, 2024
Merged
15 tasks
unlikelyzero added a commit that referenced this issue Mar 11, 2024
@ozyx @davetsay @unlikelyzero
fix(#7524): Open in New Tab action from a sub-object in a layout (#7542)
8c2558b 
* refactor: url tools use named exports

* fix: refactor method and remove customUrlParams

* test(e2e): verify bounds are preserved in data pivoting

* test: remove test as feature is no longer needed

- dataVisualization logic has moved from MMGIS plugin to the open source. As such, we can just use the time conductor bounds

* refactor: autoformat keeps changing this so i'mma just commit it

* refactor: remove unnecessary code

* refactor: simplify, add docs

* Revert "refactor: remove unnecessary code"

This reverts commit 87aef35.

* a11y: improve aria labels for ITC

* fix: simplify url method

* fix: update ITC app actions

* test: add test to generate test data for display layout w/ overlay plot + ITC enabled

* test(e2e): add suite + test for open in new tab from subobject

- needs cleanup

* a11y: various a11y improvement drivebys

* a11y: clock indicator needs to be quiet

* a11y: add `aria-live` to SuperMenu details

* a11y: greatly improve a11y of Menus and SuperMenus

* test(e2e): clean up test

* fix: improve a11y for context menus, fix test

* chore: remove nop-longer-recommended extension

* feat: provide one more bound option for example data viz

* fix: no need for `mount`, use dynamic rendering instead

* Revert "fix: simplify url method"

This reverts commit b24c7da.

* fix: correct time conductor bounds when opening in a new tab from a plot in the inspector

* test: fix e2e tests

* Revert "test: remove test as feature is no longer needed"

This reverts commit 759ebd4.

* test: move 2p annotation to test

* test: fix e2e

* fix: no words for the word god today

* test: fix e2e

* fix: e2e test

* test: fix test

* driveby: fix perf test

* fix: revert required prop change

---------

Co-authored-by: David Tsay <[email protected]>
Co-authored-by: John Hill <[email protected]>
@ozyx
Copy link
Contributor

ozyx commented Mar 12, 2024

Testing Instructions

Scenario 1

  • Open (or create) a display layout containing a LAD table
  • Click on the context menu (three-dot menu) in the LAD table and select "Open In New Tab"
  • Verify that the new tab opens to the LAD table and the url params look sane

Scenario 2

  • Create a display layout containing an Overlay Plot with some live telemetry in it
  • Save it
  • Click on the context menu (three-dot menu) in the Overlay Plot and select "Open In New Tab"
  • Verify that the new tab opens to the Overlay Plot object and the url params look sane
  • Navigate back to the display layout containing the plot
  • Activate the Independent Time Conductor on the Overlay Plot
  • Set it to "Fixed time" and change the time bounds to something else
  • Click on the context menu and open it in a new tab
  • Verify that the Overlay Plot in the new tab has the ITC activated with the same mode and bounds
  • Verify that the global time conductor has the same mode and bounds as the previous page
  • Repeat the same steps for realtime mode

@jvigliotta
Copy link
Contributor

Verified Fixed - Testathhon 3/13/24

@rukmini-bose
Copy link
Contributor

Verified Testathon 3/13/2024

@ozyx ozyx added the verified Tested or intentionally closed label Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ozyx ozyx

Labels
severity:critical type:bug verified Tested or intentionally closed
Projects
None yet
Milestone
Target:4.0.0
Development

Successfully merging a pull request may close this issue.

fix(#7524): Open in New Tab action from a sub-object in a layout nasa/openmct
4 participants
@akhenry @ozyx @jvigliotta @rukmini-bose