-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Light refactor of visual tests #5585
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5585 +/- ##
==========================================
+ Coverage 46.96% 48.27% +1.30%
==========================================
Files 643 643
Lines 25627 25627
Branches 2496 2496
==========================================
+ Hits 12036 12371 +335
+ Misses 13116 12779 -337
- Partials 475 477 +2
*This pull request uses carry forward flags. Click here to find out more.
... and 53 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Had a few minor comments.
45c50ce
to
0b8ec26
Compare
@johnhill2 Looks like there are some conflicts to resolve here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall! Just a few comments regarding selectors, and possibly some changes that got reverted in the merge?
@unlikelyzero There are conflicts. |
Current Playwright Test Results Summary✅ 14 Passing Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 08/12/2023 12:07:10am UTC) Run DetailsRunning Workflow e2e-couchdb on Github Actions Commit: 98eafd4 Started: 08/12/2023 12:05:17am UTC Current Playwright Test Results Summary✅ 133 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 08/12/2023 12:07:10am UTC)
|
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Log plot tests Log Plot ticks are functionally correct in regular and log mode and after refresh
Retry 1 • Initial Attempt |
0% (0)0 / 91 runsfailed over last 7 days |
29.67% (27)27 / 91 runsflaked over last 7 days |
📄 functional/plugins/conditionSet/conditionSet.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Basic Condition Set Use ConditionSet should output blank instead of the default value
Retry 2 • Retry 1 • Initial Attempt |
11.82% (13)13 / 110 runsfailed over last 7 days |
31.82% (35)35 / 110 runsflaked over last 7 days |
📄 functional/plugins/imagery/exampleImagery.e2e.spec.js • 2 Flakes
Top 1 Common Error Messages
|
2 Test Cases Affected |
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Example Imagery in Display Layout View Large action pauses imagery when in realtime and returns to realtime
Retry 1 • Initial Attempt |
0% (0)0 / 90 runsfailed over last 7 days |
2.22% (2)2 / 90 runsflaked over last 7 days |
Example Imagery in Display Layout Toggle layer visibility by clicking on label
Retry 1 • Initial Attempt |
0% (0)0 / 89 runsfailed over last 7 days |
1.12% (1)1 / 89 runflaked over last 7 days |
📄 functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1 • Initial Attempt |
1.10% (1)1 / 91 runfailed over last 7 days |
35.16% (32)32 / 91 runsflaked over last 7 days |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ripped out the visual suite to move here for all consumers of localStorage (i.e. mobile)
241da7f
to
160a592
Compare
Co-authored-by: John Hill <[email protected]>
Closes
Describe your changes:
All Submissions:
Author Checklist
Reviewer Checklist