Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance telemetry tables to allow in place updates for data #6694

Merged
merged 18 commits into from
Jul 14, 2023

Conversation

shefalijoshi
Copy link
Contributor

@shefalijoshi shefalijoshi commented May 25, 2023

See: akhenry/openmct-yamcs#315

Describe your changes:

Sometimes telemetry data for a single data row in telemetry tables comes in parts (via subscriptions).
But the desire is to view only one row for that datum instead of multiple rows for each part.
If the metadata for a telemetry endpoint indicates that the datum should be aggregated into one row, then the table will do so.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

jvigliotta and others added 9 commits May 11, 2023 17:51
#6658)

cherry-pick(#6602) : [ExportAsJson] Multiple Aliases in Export and Conditional Styles Fixes (#6602)

Fixes issues that prevent import and export from being completed successfully. Specifically:

* if multiple aliases are detected, the first is created as a new object and and added to it's parent's composition, any subsequent aliases of the same object will not be recreated, but the originally created one will be added to the current parent's composition, creating an alias.

* Also, there are cases were conditionSetIdentifiers are stored in an object keyed by an item id in the configuration.objectstyles object, this fix will handle these as well.

* Replaces an errant `return` statement with a `continue` statement to prevent early exit from a recursive function.

---------

Co-authored-by: Andrew Henry <[email protected]>
@deploysentinel
Copy link

deploysentinel bot commented May 25, 2023

Current Playwright Test Results Summary

✅ 14 Passing

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 07/14/2023 08:34:44pm UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: 7b44af1

Started: 07/14/2023 08:29:14pm UTC

View Detailed Build Results


Current Playwright Test Results Summary

✅ 133 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 07/14/2023 08:34:44pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 7b44af1

Started: 07/14/2023 08:27:56pm UTC

⚠️ Flakes

📄   functional/plugins/imagery/exampleImagery.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Example Imagery Object Can use Mouse Wheel to zoom in and out of latest image
Retry 1Initial Attempt
0.57% (1) 1 / 175 run
failed over last 7 days
78.29% (137) 137 / 175 runs
flaked over last 7 days

View Detailed Build Results


@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #6694 (7b44af1) into master (6e79e5e) will increase coverage by 0.32%.
The diff coverage is 34.69%.

@@            Coverage Diff             @@
##           master    #6694      +/-   ##
==========================================
+ Coverage   53.40%   53.73%   +0.32%     
==========================================
  Files         631      631              
  Lines       25114    25146      +32     
  Branches     2520     2520              
==========================================
+ Hits        13413    13512      +99     
+ Misses      11026    10960      -66     
+ Partials      675      674       -1     
Flag Coverage Δ *Carryforward flag
e2e-full 42.26% <ø> (+0.04%) ⬆️ Carriedforward from 656d9ca
e2e-stable 55.62% <30.61%> (+3.44%) ⬆️
unit 48.26% <34.69%> (-0.07%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...s/telemetryTable/collections/TableRowCollection.js 45.32% <6.45%> (-7.18%) ⬇️
src/plugins/telemetryTable/TelemetryTableRow.js 82.05% <57.14%> (-5.83%) ⬇️
src/api/telemetry/TelemetryMetadataManager.js 80.70% <100.00%> (+1.45%) ⬆️
src/plugins/telemetryTable/TelemetryTable.js 79.42% <100.00%> (+0.35%) ⬆️

... and 26 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e79e5e...7b44af1. Read the comment docs.

@unlikelyzero unlikelyzero added the type:feature Feature. Required intentional design label Jun 2, 2023
@unlikelyzero unlikelyzero self-requested a review June 2, 2023 18:29
Copy link
Collaborator

@unlikelyzero unlikelyzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's sync when you have a chance to define the tests we want to add for this feature

@akhenry akhenry self-requested a review June 30, 2023 21:28
akhenry

This comment was marked as outdated.

@akhenry akhenry self-requested a review July 10, 2023 21:00
Copy link
Contributor

@akhenry akhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really great! I've suggested one change which is relatively small and I think will make it a little more flexible for future applications of this sort of row matching.

src/plugins/telemetryTable/TelemetryTable.js Outdated Show resolved Hide resolved
@akhenry akhenry added the pr:e2e:couchdb npm run test:e2e:couchdb label Jul 14, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature Feature. Required intentional design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants