-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance telemetry tables to allow in place updates for data #6694
Conversation
#6658) cherry-pick(#6602) : [ExportAsJson] Multiple Aliases in Export and Conditional Styles Fixes (#6602) Fixes issues that prevent import and export from being completed successfully. Specifically: * if multiple aliases are detected, the first is created as a new object and and added to it's parent's composition, any subsequent aliases of the same object will not be recreated, but the originally created one will be added to the current parent's composition, creating an alias. * Also, there are cases were conditionSetIdentifiers are stored in an object keyed by an item id in the configuration.objectstyles object, this fix will handle these as well. * Replaces an errant `return` statement with a `continue` statement to prevent early exit from a recursive function. --------- Co-authored-by: Andrew Henry <[email protected]>
Current Playwright Test Results Summary✅ 14 Passing Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 07/14/2023 08:34:44pm UTC) Run DetailsRunning Workflow e2e-couchdb on Github Actions Commit: 7b44af1 Started: 07/14/2023 08:29:14pm UTC Current Playwright Test Results Summary✅ 133 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 07/14/2023 08:34:44pm UTC)
|
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Example Imagery Object Can use Mouse Wheel to zoom in and out of latest image
Retry 1 • Initial Attempt |
0.57% (1)1 / 175 runfailed over last 7 days |
78.29% (137)137 / 175 runsflaked over last 7 days |
Codecov Report
@@ Coverage Diff @@
## master #6694 +/- ##
==========================================
+ Coverage 53.40% 53.73% +0.32%
==========================================
Files 631 631
Lines 25114 25146 +32
Branches 2520 2520
==========================================
+ Hits 13413 13512 +99
+ Misses 11026 10960 -66
+ Partials 675 674 -1
*This pull request uses carry forward flags. Click here to find out more.
... and 26 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…-inplace-updates-tables
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's sync when you have a chance to define the tests we want to add for this feature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really great! I've suggested one change which is relatively small and I think will make it a little more flexible for future applications of this sort of row matching.
See: akhenry/openmct-yamcs#315
Describe your changes:
Sometimes telemetry data for a single data row in telemetry tables comes in parts (via subscriptions).
But the desire is to view only one row for that datum instead of multiple rows for each part.
If the metadata for a telemetry endpoint indicates that the datum should be aggregated into one row, then the table will do so.
All Submissions:
Author Checklist
Reviewer Checklist