-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batch annotation requests #6719
Batch annotation requests #6719
Conversation
…a-large-number-of-plots-take-a-long-time-to-load-due-to-annotation-requests
Current Playwright Test Results Summary✅ 13 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 06/15/2023 11:47:52pm UTC) Run DetailsRunning Workflow e2e-couchdb on Github Actions Commit: 526b072 Started: 06/15/2023 11:44:47pm UTC
|
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Main Tree Creating a child object on one tab and expanding its parent on the other shows the correct composition @couchdb @2p
Retry 1 • Initial Attempt |
0% (0)0 / 22 runsfailed over last 7 days |
13.64% (3)3 / 22 runsflaked over last 7 days |
📄 functional/plugins/notebook/notebookWithCouchDB.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Notebook Tests with CouchDB @couchdb Inspect Notebook Entry Network Requests
Retry 1 • Initial Attempt |
4.55% (1)1 / 22 runfailed over last 7 days |
36.36% (8)8 / 22 runsflaked over last 7 days |
Codecov Report
@@ Coverage Diff @@
## master #6719 +/- ##
==========================================
- Coverage 54.17% 53.95% -0.23%
==========================================
Files 623 623
Lines 24609 24634 +25
Branches 2464 2464
==========================================
- Hits 13332 13291 -41
- Misses 10611 10683 +72
+ Partials 666 660 -6
*This pull request uses carry forward flags. Click here to find out more.
... and 13 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…-take-a-long-time-to-load-due-to-annotation-requests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We tested this in a pre-production environment. The 100ms is not good enough for some batching on the VPN, but not an issue when hard wired or in the same lab.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #6708
Describe your changes:
Batches annotation requests with a 100ms debounce. This helps things like display layouts with lots of plots, notebooks, etc. to only ask for annotations once.
All Submissions:
Author Checklist
Reviewer Checklist