Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch annotation requests #6719

Conversation

scottbell
Copy link
Contributor

@scottbell scottbell commented Jun 12, 2023

Closes #6708

Describe your changes:

Batches annotation requests with a 100ms debounce. This helps things like display layouts with lots of plots, notebooks, etc. to only ask for annotations once.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@deploysentinel
Copy link

deploysentinel bot commented Jun 12, 2023

Current Playwright Test Results Summary

✅ 13 Passing - ⚠️ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 06/15/2023 11:47:52pm UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: 526b072

Started: 06/15/2023 11:44:47pm UTC

⚠️ Flakes

📄   functional/tree.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Main Tree Creating a child object on one tab and expanding its parent on the other shows the correct composition @couchdb @2p
Retry 1Initial Attempt
0% (0) 0 / 22 runs
failed over last 7 days
13.64% (3) 3 / 22 runs
flaked over last 7 days

📄   functional/plugins/notebook/notebookWithCouchDB.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Notebook Tests with CouchDB @couchdb Inspect Notebook Entry Network Requests
Retry 1Initial Attempt
4.55% (1) 1 / 22 run
failed over last 7 days
36.36% (8) 8 / 22 runs
flaked over last 7 days

View Detailed Build Results


@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Jun 12, 2023
@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #6719 (ea7c5e4) into master (9a01cee) will decrease coverage by 0.23%.
The diff coverage is 11.11%.

@@            Coverage Diff             @@
##           master    #6719      +/-   ##
==========================================
- Coverage   54.17%   53.95%   -0.23%     
==========================================
  Files         623      623              
  Lines       24609    24634      +25     
  Branches     2464     2464              
==========================================
- Hits        13332    13291      -41     
- Misses      10611    10683      +72     
+ Partials      666      660       -6     
Flag Coverage Δ *Carryforward flag
e2e-full 31.20% <ø> (-0.01%) ⬇️ Carriedforward from 6878f06
e2e-stable 55.16% <3.70%> (-0.09%) ⬇️
unit 48.79% <11.11%> (-0.32%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...c/plugins/persistence/couch/CouchSearchProvider.js 44.68% <11.11%> (-46.23%) ⬇️

... and 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a01cee...ea7c5e4. Read the comment docs.

@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Jun 12, 2023
…-take-a-long-time-to-load-due-to-annotation-requests
@unlikelyzero unlikelyzero self-requested a review June 15, 2023 23:39
@unlikelyzero unlikelyzero added this to the Target:2.2.5 milestone Jun 15, 2023
Copy link
Collaborator

@unlikelyzero unlikelyzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We tested this in a pre-production environment. The 100ms is not good enough for some batching on the VPN, but not an issue when hard wired or in the same lab.

@unlikelyzero unlikelyzero added the pr:e2e:couchdb npm run test:e2e:couchdb label Jun 15, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Jun 15, 2023
Copy link
Contributor

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ozyx ozyx merged commit fb5bbde into master Jun 16, 2023
@ozyx ozyx deleted the 6708-displays-with-a-large-number-of-plots-take-a-long-time-to-load-due-to-annotation-requests branch June 16, 2023 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Displays with a large number of plots take a long time to load due to annotation requests
3 participants