-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tree item abort #6757
Tree item abort #6757
Conversation
Current Playwright Test Results Summary✅ 14 Passing Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 07/14/2023 05:48:56pm UTC) Run DetailsRunning Workflow e2e-couchdb on Github Actions Commit: 7a389fa Started: 07/14/2023 05:46:03pm UTC Current Playwright Test Results Summary✅ 133 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 07/14/2023 05:48:56pm UTC)
|
|
3 Test Cases Affected |
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Condition Set CRUD Operations on @localStorage Condition set object properties persist in main view and inspector @localStorage
Retry 1 • Initial Attempt |
-0.70% (-1)-1 / 142 runsfailed over last 7 days |
8.45% (12)12 / 142 runsflaked over last 7 days |
Condition Set CRUD Operations on @localStorage condition set object can be modified on @localStorage
Retry 1 • Initial Attempt |
-9.16% (-12)-12 / 131 runsfailed over last 7 days |
9.16% (12)12 / 131 runsflaked over last 7 days |
Condition Set CRUD Operations on @localStorage condition set object can be deleted by Search Tree Actions menu on @localStorage
Retry 1 • Initial Attempt |
-8.40% (-11)-11 / 131 runsfailed over last 7 days |
9.16% (12)12 / 131 runsflaked over last 7 days |
📄 functional/plugins/imagery/exampleImagery.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Example Imagery Object Can use Mouse Wheel to zoom in and out of latest image
Retry 1 • Initial Attempt |
0.65% (1)1 / 155 runfailed over last 7 days |
80% (124)124 / 155 runsflaked over last 7 days |
Codecov Report
@@ Coverage Diff @@
## master #6757 +/- ##
==========================================
+ Coverage 52.92% 53.78% +0.86%
==========================================
Files 628 628
Lines 25021 25027 +6
Branches 2505 2508 +3
==========================================
+ Hits 13242 13462 +220
+ Misses 11106 10893 -213
+ Partials 673 672 -1
*This pull request uses carry forward flags. Click here to find out more.
... and 44 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great overall, just had one question for you regarding AbortError
handling in the CouchObjectProvider
…ated tree and tree test to utilize that new feature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small nitpick that you can take or leave, but LGTM otherwise!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, a little confused about the previous test failure though. False positive?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, ship it.
This is blocked on a real bug on the couchdb tests |
Closes #6753
Describe your changes:
Grabbing the abort signal in the tree and passing it to
composition.load
so requests can be canceled if item closed.Suppressing all console.error's for aborted requests in couch. This information is available in the network tab.
Added an e2e regression test for this feature.
All Submissions:
Author Checklist
Reviewer Checklist