Fix couchdbsearchfolder and allow clocky reports #6770

shefalijoshi · 2023-06-30T14:46:36Z

Closes VIPEROMCT-62 and #6794

Describe your changes:

Adds unique identifiers for couchdbsearchfolder since multiple instances of the folders was overwriting the original with a hardcoded name

All Submissions:

Have you followed the guidelines in our Contributing document?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?
Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

Changes address original issue?
Tests included and/or updated with changes?
Command line build passes?
Has this been smoke tested?
Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

Changes appear to address issue?
Reviewer has tested changes by following the provided instructions?
Changes appear not to be breaking changes?
Appropriate automated tests included?
Code style and in-line documentation are appropriate?
Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

Allow ttt-reports to be viewed as web pages

…d to the viper-openmct repo instead

deploysentinel · 2023-06-30T14:50:59Z

Current Playwright Test Results Summary

✅ 13 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 07/13/2023 07:50:35pm UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: 22ea533

Started: 07/13/2023 07:45:39pm UTC

⚠️ Flakes

📄 functional/plugins/displayLayout/displayLayout.e2e.spec.js • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Display Layout When multiple plots are contained in a layout, we only ask for annotations once @couchdb Retry 1 • Initial Attempt	2.86% (1) 1 / 35 run failed over last 7 days	14.29% (5) 5 / 35 runs flaked over last 7 days

View Detailed Build Results

Current Playwright Test Results Summary

✅ 123 Passing - ⚠️ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 07/13/2023 07:50:35pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 22ea533

Started: 07/13/2023 07:45:02pm UTC

⚠️ Flakes

📄 functional/plugins/plot/tagging.e2e.spec.js • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Plot Tagging Tags work with Plot View of telemetry items Retry 1 • Initial Attempt	0% (0) 0 / 72 runs failed over last 7 days	25% (18) 18 / 72 runs flaked over last 7 days

📄 functional/plugins/imagery/exampleImagery.e2e.spec.js • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Example Imagery Object Can use Mouse Wheel to zoom in and out of latest image Retry 1 • Initial Attempt	1.69% (2) 2 / 118 runs failed over last 7 days	77.12% (91) 91 / 118 runs flaked over last 7 days

View Detailed Build Results

codecov · 2023-06-30T14:52:10Z

Codecov Report

Merging #6770 (682a452) into master (ac22beb) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #6770      +/-   ##
==========================================
+ Coverage   53.73%   53.78%   +0.05%     
==========================================
  Files         624      624              
  Lines       24898    24901       +3     
  Branches     2498     2498              
==========================================
+ Hits        13378    13394      +16     
+ Misses      10848    10836      -12     
+ Partials      672      671       -1

Flag	Coverage Δ		*Carryforward flag
e2e-full	`42.16% <ø> (+<0.01%)`	⬆️	Carriedforward from ac22beb
e2e-stable	`55.43% <0.00%> (+0.27%)`	⬆️
unit	`48.52% <100.00%> (+0.05%)`	⬆️

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files	Coverage Δ
src/plugins/viewLargeAction/viewLargeAction.js	`88.88% <ø> (ø)`
src/plugins/CouchDBSearchFolder/plugin.js	`92.85% <100.00%> (+1.94%)`	⬆️

... and 5 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac22beb...682a452. Read the comment docs.

unlikelyzero

Let's deploy this to dev on Wednesday

unlikelyzero · 2023-07-07T19:19:20Z

src/plugins/viewLargeAction/viewLargeAction.js

@@ -54,7 +54,7 @@ export default class ViewLargeAction {

    return (
      childElement &&
-      !childElement.classList.contains('js-main-container') &&
+      !childElement?.classList.contains('js-main-container') &&


is there an issue for this?

No there isn't an issue. I'm unsure why this issue happened or how to reproduce it too.

unlikelyzero · 2023-07-07T19:23:58Z

To test:

Verify countdown and timelist continues to work when referencing a plan on our dev environment
Verify couchdb e2e tests pass
Update unit tests

akhenry · 2023-07-10T21:03:15Z

@unlikelyzero to regression test plans

…eports

unlikelyzero · 2023-07-11T21:58:21Z

@shefalijoshi I see the following error on dev after deploying the latest and attempting to access an existing plan

shefalijoshi · 2023-07-12T00:06:37Z

@shefalijoshi I see the following error on dev after deploying the latest and attempting to access an existing plan

OK this should be fixed now. Good find!

unlikelyzero

Can you file an issue to test for the viewLargeAction.js change for testathon?

…eports

jvigliotta

Just have a question!

jvigliotta · 2023-07-12T03:53:03Z

src/plugins/CouchDBSearchFolder/plugin.js

  return function install(openmct) {
    const couchProvider = couchPlugin.couchProvider;
+    //replace any non-letter/non-number with a hyphen
+    const couchSearchId = (folderName || DEFAULT_NAME).replace(/[^a-zA-Z0-9]/g, '-');


Would there ever be a situation where folderName isn't passed in? seems unlikely if couchPlugin and searchFilter are expected?

Correct. But this was in case someone put in empty string or something.

shefalijoshi · 2023-07-12T03:54:48Z

Can you file an issue to test for the viewLargeAction.js change for testathon?

#6794

…eports

jvigliotta

Looks good to me!

…eports

shefalijoshi added 2 commits June 29, 2023 12:54

Fix CouchDBSearchFolder plugin to have unique identifiers.

a2deaf6

Allow ttt-reports to be viewed as web pages

Remove ttt-report type from WebPage view provider. This is being move…

efd3556

…d to the viper-openmct repo instead

shefalijoshi requested a review from jvigliotta June 30, 2023 17:36

unlikelyzero self-requested a review July 3, 2023 15:33

unlikelyzero added the type:feature Feature. Required intentional design label Jul 3, 2023

unlikelyzero requested changes Jul 3, 2023

View reviewed changes

shefalijoshi added 2 commits July 5, 2023 13:30

Adds check for classList

ac34685

Add WebPage to the components list

42296cf

shefalijoshi requested a review from unlikelyzero July 7, 2023 17:35

unlikelyzero added the pr:e2e:couchdb npm run test:e2e:couchdb label Jul 7, 2023

unlikelyzero reviewed Jul 7, 2023

View reviewed changes

github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Jul 7, 2023

Remove uuid and use the folder name as the identifier instead

dcf2385

shefalijoshi requested a review from unlikelyzero July 11, 2023 13:54

shefalijoshi and others added 2 commits July 11, 2023 06:54

Remove focused test

d2eb3e1

Merge branch 'master' into fix-couchdbsearchfolder-and-allow-clocky-r…

9555805

…eports

unlikelyzero added the pr:e2e:couchdb npm run test:e2e:couchdb label Jul 11, 2023

github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Jul 11, 2023

unlikelyzero added this to the Target:2.2.6 milestone Jul 12, 2023

unlikelyzero requested changes Jul 12, 2023

View reviewed changes

Merge branch 'master' into fix-couchdbsearchfolder-and-allow-clocky-r…

e8287f6

…eports

shefalijoshi requested a review from unlikelyzero July 12, 2023 03:41

jvigliotta reviewed Jul 12, 2023

View reviewed changes

shefalijoshi requested a review from jvigliotta July 12, 2023 04:04

Merge branch 'master' into fix-couchdbsearchfolder-and-allow-clocky-r…

682a452

…eports

jvigliotta enabled auto-merge (squash) July 12, 2023 19:04

jvigliotta approved these changes Jul 12, 2023

View reviewed changes

jvigliotta added the pr:e2e:couchdb npm run test:e2e:couchdb label Jul 12, 2023

github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Jul 12, 2023

unlikelyzero approved these changes Jul 13, 2023

View reviewed changes

Merge branch 'master' into fix-couchdbsearchfolder-and-allow-clocky-r…

22ea533

…eports

unlikelyzero added the pr:e2e:couchdb npm run test:e2e:couchdb label Jul 13, 2023

github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Jul 13, 2023

jvigliotta merged commit 795d7a7 into master Jul 13, 2023

jvigliotta deleted the fix-couchdbsearchfolder-and-allow-clocky-reports branch July 13, 2023 19:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix couchdbsearchfolder and allow clocky reports #6770

Fix couchdbsearchfolder and allow clocky reports #6770

shefalijoshi commented Jun 30, 2023 •

edited

Loading

deploysentinel bot commented Jun 30, 2023 •

edited

Loading

Test Case Results

Test Case Results

Test Case Results

codecov bot commented Jun 30, 2023 •

edited

Loading

unlikelyzero left a comment

unlikelyzero Jul 7, 2023

shefalijoshi Jul 12, 2023

unlikelyzero commented Jul 7, 2023 •

edited

Loading

akhenry commented Jul 10, 2023

unlikelyzero commented Jul 11, 2023 •

edited

Loading

shefalijoshi commented Jul 12, 2023

unlikelyzero left a comment

jvigliotta left a comment

jvigliotta Jul 12, 2023

shefalijoshi Jul 12, 2023

shefalijoshi commented Jul 12, 2023

jvigliotta left a comment

Fix couchdbsearchfolder and allow clocky reports #6770

Fix couchdbsearchfolder and allow clocky reports #6770

Conversation

shefalijoshi commented Jun 30, 2023 • edited Loading

Describe your changes:

All Submissions:

Author Checklist

Reviewer Checklist

deploysentinel bot commented Jun 30, 2023 • edited Loading

Current Playwright Test Results Summary

⚠️ Flakes

Test Case Results

Current Playwright Test Results Summary

⚠️ Flakes

Test Case Results

Test Case Results

codecov bot commented Jun 30, 2023 • edited Loading

Codecov Report

unlikelyzero left a comment

Choose a reason for hiding this comment

unlikelyzero Jul 7, 2023

Choose a reason for hiding this comment

shefalijoshi Jul 12, 2023

Choose a reason for hiding this comment

unlikelyzero commented Jul 7, 2023 • edited Loading

akhenry commented Jul 10, 2023

unlikelyzero commented Jul 11, 2023 • edited Loading

shefalijoshi commented Jul 12, 2023

unlikelyzero left a comment

Choose a reason for hiding this comment

jvigliotta left a comment

Choose a reason for hiding this comment

jvigliotta Jul 12, 2023

Choose a reason for hiding this comment

shefalijoshi Jul 12, 2023

Choose a reason for hiding this comment

shefalijoshi commented Jul 12, 2023

jvigliotta left a comment

Choose a reason for hiding this comment

shefalijoshi commented Jun 30, 2023 •

edited

Loading

deploysentinel bot commented Jun 30, 2023 •

edited

Loading

codecov bot commented Jun 30, 2023 •

edited

Loading

unlikelyzero commented Jul 7, 2023 •

edited

Loading

unlikelyzero commented Jul 11, 2023 •

edited

Loading