Switch staleness provider for SWG to use modeChanged instead of clock #6845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eliminate ambiguity when looking for time conductor locator
…with independent time contexts
…added the first time.
Fix tests for flexible layout and timestrip
…o be deleted from a locked page - Using `this.$delete(arr, index)` does not update the `length` property on the underlying target object, so it can lead to bizarre issues where your array is of length 4 but it has 3 objects in it.
This reverts commit d888553.
* Turn off the clock ticket for independent time conductor when it is disabled * Fix linting issues --------- Co-authored-by: Khalid Adil <[email protected]>
- Using `indexOf()` with an object was failing due to some items in the tree being Proxy-wrapped and others not. So instead, use `findIndex()` with a predicate that compares the navigationPaths of both objects
* removing an unneccessary refresh that waas causing many get requests * lets just pretend this never happened
#6840) Hide change role button in the indicator in cases where there is only a single role available for the current user
- CSS fixes for Firefox for popup width and input widths. - Changed markup and CSS for Safari - Cannot apply CSS grid to form. - Changed ul/li approach to calendar picker, other CSS mods (align-items: center) to fix height issues. - Modded _constants value to account for reduced height of new TC design. - Resolved conflicts while applying stashed changes.
Current Playwright Test Results Summary✅ 14 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 07/28/2023 05:04:25am UTC) Run DetailsRunning Workflow e2e-couchdb on Github Actions Commit: 9e582bd Started: 07/28/2023 05:01:54am UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Display Layout When multiple plots are contained in a layout, we only ask for annotations once @couchdb
Retry 2 • Retry 1 • Initial Attempt |
6.25% (2)2 / 32 runsfailed over last 7 days |
12.50% (4)4 / 32 runsflaked over last 7 days |
Current Playwright Test Results Summary
✅ 131 Passing -
Run may still be in progress, this comment will be updated as current testing workflow or job completes...
(Last updated on 07/28/2023 05:04:25am UTC)
⚠️ Flakes
📄 functional/plugins/conditionSet/conditionSet.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Basic Condition Set Use ConditionSet should output blank instead of the default value
Retry 1 • Initial Attempt |
11.36% (5)5 / 44 runsfailed over last 7 days |
31.82% (14)14 / 44 runsflaked over last 7 days |
📄 functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1 • Initial Attempt |
5.13% (2)2 / 39 runsfailed over last 7 days |
20.51% (8)8 / 39 runsflaked over last 7 days |
Codecov Report
@@ Coverage Diff @@
## master #6845 +/- ##
==========================================
+ Coverage 48.18% 48.20% +0.01%
==========================================
Files 643 643
Lines 25620 25620
Branches 2512 2512
==========================================
+ Hits 12346 12350 +4
+ Misses 12797 12793 -4
Partials 477 477
*This pull request uses carry forward flags. Click here to find out more.
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Closed
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6339
Describe your changes:
Switch staleness provider for SWG to use modeChanged instead of clock
All Submissions:
Author Checklist
Reviewer Checklist