Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move indexTest to kebab-case #6860

Merged
merged 1 commit into from
Aug 6, 2023
Merged

Conversation

evenstensberg
Copy link
Contributor

Describe your changes:

kebabcase is used for the entire pwd of the root.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@deploysentinel
Copy link

deploysentinel bot commented Jul 31, 2023

Current Playwright Test Results Summary

✅ 134 Passing - ⚠️ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/06/2023 07:50:45pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: c89af11

Started: 08/06/2023 07:45:20pm UTC

⚠️ Flakes

📄   functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1Initial Attempt
0% (0) 0 / 87 runs
failed over last 7 days
20.69% (18) 18 / 87 runs
flaked over last 7 days
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1Initial Attempt
0% (0) 0 / 87 runs
failed over last 7 days
26.44% (23) 23 / 87 runs
flaked over last 7 days

View Detailed Build Results


@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #6860 (c89af11) into master (4287cd5) will decrease coverage by 0.47%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6860      +/-   ##
==========================================
- Coverage   48.40%   47.94%   -0.47%     
==========================================
  Files         644      643       -1     
  Lines       25628    25626       -2     
  Branches     2496     2496              
==========================================
- Hits        12405    12286     -119     
- Misses      12750    12863     +113     
- Partials      473      477       +4     
Flag Coverage Δ *Carryforward flag
e2e-full 42.06% <ø> (ø) Carriedforward from 4287cd5
e2e-stable 55.25% <ø> (-1.92%) ⬇️
unit 38.71% <ø> (-0.09%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 29 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4287cd5...c89af11. Read the comment docs.

@ozyx ozyx added the source:community Community contribution or request label Jul 31, 2023
Copy link
Contributor

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consistency is a wonderful thing. Thanks for this!

@ozyx ozyx enabled auto-merge (squash) August 3, 2023 17:07
@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 3, 2023
@ozyx
Copy link
Contributor

ozyx commented Aug 3, 2023

@unlikelyzero I think this is blocked for merge due to the way GHA runs against this, we lose envvars for dockerhub

@evenstensberg
Copy link
Contributor Author

@ozyx feel free to add me to the NASA org 😆

@ozyx ozyx added pr:e2e:couchdb npm run test:e2e:couchdb and removed pr:e2e:couchdb npm run test:e2e:couchdb labels Aug 4, 2023
@unlikelyzero
Copy link
Collaborator

@evenstensberg please rebase on master. I believe we've fixed #6890

auto-merge was automatically disabled August 6, 2023 15:55

Head branch was pushed to by a user without write access

@evenstensberg
Copy link
Contributor Author

Rebased

@unlikelyzero unlikelyzero added pr:e2e:couchdb npm run test:e2e:couchdb and removed pr:e2e:couchdb npm run test:e2e:couchdb labels Aug 6, 2023
@unlikelyzero unlikelyzero merged commit 9942bbb into nasa:master Aug 6, 2023
9 checks passed
@shefalijoshi shefalijoshi added the type:maintenance tests, chores, or project maintenance label Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:e2e:couchdb npm run test:e2e:couchdb source:community Community contribution or request type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants