-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move indexTest to kebab-case #6860
Conversation
Current Playwright Test Results Summary✅ 134 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 08/06/2023 07:50:45pm UTC)
|
|
2 Test Cases Affected |
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1 • Initial Attempt |
0% (0)0 / 87 runsfailed over last 7 days |
20.69% (18)18 / 87 runsflaked over last 7 days |
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1 • Initial Attempt |
0% (0)0 / 87 runsfailed over last 7 days |
26.44% (23)23 / 87 runsflaked over last 7 days |
Codecov Report
@@ Coverage Diff @@
## master #6860 +/- ##
==========================================
- Coverage 48.40% 47.94% -0.47%
==========================================
Files 644 643 -1
Lines 25628 25626 -2
Branches 2496 2496
==========================================
- Hits 12405 12286 -119
- Misses 12750 12863 +113
- Partials 473 477 +4
*This pull request uses carry forward flags. Click here to find out more. see 29 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consistency is a wonderful thing. Thanks for this!
@unlikelyzero I think this is blocked for merge due to the way GHA runs against this, we lose envvars for dockerhub |
@ozyx feel free to add me to the NASA org 😆 |
@evenstensberg please rebase on master. I believe we've fixed #6890 |
Head branch was pushed to by a user without write access
Rebased |
Describe your changes:
kebabcase is used for the entire pwd of the root.
All Submissions:
Author Checklist
Reviewer Checklist