chore: add vue3 to eslint, fix errors, and modify lint script #6910
Conversation
Current Playwright Test Results Summary✅ 14 Passing Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 08/14/2023 05:03:03pm UTC) Run DetailsRunning Workflow e2e-couchdb on Github Actions Commit: f063941 Started: 08/14/2023 05:00:51pm UTC Current Playwright Test Results Summary✅ 133 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 08/14/2023 05:03:03pm UTC)
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Log plot tests Log Plot ticks are functionally correct in regular and log mode and after refresh
Retry 1 • Initial Attempt |
0% (0)0 / 101 runsfailed over last 7 days |
37.62% (38)38 / 101 runsflaked over last 7 days |
Codecov Report
@@ Coverage Diff @@
## master #6910 +/- ##
==========================================
- Coverage 48.39% 48.32% -0.08%
==========================================
Files 643 643
Lines 25627 25627
Branches 2496 2496
==========================================
- Hits 12401 12383 -18
- Misses 12751 12768 +17
- Partials 475 476 +1
*This pull request uses carry forward flags. Click here to find out more.
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| @@ -28,6 +28,8 @@ module.exports = { | |||
| } | |||
| }, | |||
| rules: { | |||
| 'vue/no-deprecated-dollar-listeners-api': 'warn', | |||
There was a problem hiding this comment.
Which of these two are due to our proxy migration path?
There was a problem hiding this comment.
Both warnings are required in order to upgrade fully to Vue 3. The fix is not trivial (though not complicated), so I'm allowing warnings here so we can work these out and eventually disallow warnings again once we upgrade.
| @@ -81,7 +81,7 @@ | |||
| "clean-test-lint": "npm run clean; npm install; npm run test; npm run lint; npm run lint:spelling", | |||
| "start": "npx webpack serve --config ./.webpack/webpack.dev.js", | |||
| "start:coverage": "npx webpack serve --config ./.webpack/webpack.coverage.js", | |||
| "lint": "eslint example src e2e --ext .js,.vue openmct.js --max-warnings=0", | |||
| "lint": "eslint example src e2e --ext .js openmct.js --max-warnings=0 && eslint example src --ext .vue", | |||
… lint script (#6935) * cherry-pick(#6910): chore: add vue3 to eslint, fix errors, and modify lint script * refactor: lint:fix --------- Co-authored-by: John Hill <[email protected]>
Closes #6909
Describe your changes:
Updates our eslint config to include Vue 3 recommended rules. Edits some existing and non-pertinent rules to be warnings. Splits our linting step into two discrete steps, one that lints against *.js files and accepts no warnings, and another that lints against *.vue files and produces warnings in addition to errors. This is to help guide developers on what needs to change in order for us to complete the migration to Vue 3.
All Submissions:
Author Checklist
Reviewer Checklist