Fix remote clock subscription #6919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e + update `Vue.extend()` usage to Vue 3 (#6873) * fix: update to `defineComponent` from `Vue.extend()` * fix: unwrap Proxy arg before WeakMap.get() * refactor: `defineComponent` not needed here
…args (#6881) fix: suppress deprecation warnings to once per unique args (#6875) Co-authored-by: Jesse Mazzella <[email protected]>
…raw series limits (#6883) * Set the raw series limits so that we can get the raw series limits * fix: `toRaw()` the other gets/sets/deletes --------- Co-authored-by: Shefali Joshi <[email protected]>
* created a throttle util and using it in timer plugin to throttle refreshing the timer domain object * Simplify timer logic * Clarify code a little * refactor: lint:fix * Fix linting issue --------- Co-authored-by: Andrew Henry <[email protected]> Co-authored-by: Jamie V <[email protected]>
#6902) Only load annotations in fixed time mode or frozen (#6866) * fix annotations load to not happen on start * remove range checking per annotated point * back to local variable * reduce tagging size to improve reliability of test * remove .only * remove .only * reduce hz rate for functional test and keep high frequency test in performance * remove console.debugs * this test runs pretty fast now * fix network request tests to match new behavior
check for null before checking before hasOwnProperty Co-authored-by: Scott Bell <[email protected]>
…g after getting the domain object details
Current Playwright Test Results Summary✅ 14 Passing Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 08/14/2023 09:51:34pm UTC) Run DetailsRunning Workflow e2e-couchdb on Github Actions Commit: 5de9da4 Started: 08/14/2023 09:49:18pm UTC Current Playwright Test Results Summary✅ 133 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 08/14/2023 09:51:34pm UTC)
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Telemetry Table unpauses and filters data when paused by button and user changes bounds
Retry 1 • Initial Attempt |
1.63% (2)2 / 123 runsfailed over last 7 days |
15.45% (19)19 / 123 runsflaked over last 7 days |
📄 functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1 • Initial Attempt |
0.79% (1)1 / 127 runfailed over last 7 days |
42.52% (54)54 / 127 runsflaked over last 7 days |
📄 functional/plugins/imagery/exampleImagery.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Example Imagery in Display Layout View Large action pauses imagery when in realtime and returns to realtime
Retry 1 • Initial Attempt |
0% (0)0 / 126 runsfailed over last 7 days |
4.76% (6)6 / 126 runsflaked over last 7 days |
Codecov Report
@@ Coverage Diff @@
## master #6919 +/- ##
=======================================
Coverage 48.35% 48.36%
=======================================
Files 643 643
Lines 25627 25629 +2
Branches 2496 2496
=======================================
+ Hits 12393 12396 +3
+ Misses 12760 12756 -4
- Partials 474 477 +3
*This pull request uses carry forward flags. Click here to find out more.
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…ote-clock-subscription
…sa/openmct into fix-remote-clock-subscription
ozyx
suggested changes
Aug 11, 2023
ozyx
pushed a commit
that referenced
this pull request
Aug 14, 2023
* If there are no listeners for this clock then don't bother subscribing after getting the domain object details * Comment explaining the fix
unlikelyzero
pushed a commit
that referenced
this pull request
Aug 16, 2023
* If there are no listeners for this clock then don't bother subscribing after getting the domain object details * Comment explaining the fix Co-authored-by: Shefali Joshi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes VIPEROMCT-394
Describe your changes:
Sometimes the domain object details arrive AFTER the clock for Open MCT has been changed. In this case, we check if there are no listeners for this clock then don't bother subscribing for the remote telemetry data.
All Submissions:
Author Checklist
Reviewer Checklist