feat(tooling): adds nvm

[evenstensberg]

#6888

Closing #6956

Describe your changes:

Adds nvmrc to use same node and npm version throughout the project.

All Submissions:

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?
• Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

• Changes address original issue?
• Tests included and/or updated with changes?
• Command line build passes?
• Has this been smoke tested?
• Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

• Changes appear to address issue?
• Reviewer has tested changes by following the provided instructions?
• Changes appear not to be breaking changes?
• Appropriate automated tests included?
• Code style and in-line documentation are appropriate?
• Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
• Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

[deploysentinel]

Current Playwright Test Results Summary

✅ 136 Passing - ⚠️ 4 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/19/2023 08:16:08pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: b8a3d19

Started: 08/19/2023 08:09:08pm UTC

⚠️ Flakes

📄   functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 2 Flakes

Top 1 Common Error Messages

null	2 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit Retry 1 • Initial Attempt	0% (0) 0 / 150 runs failed over last 7 days	45.33% (68) 68 / 150 runs flaked over last 7 days
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit Retry 1 • Initial Attempt	0% (0) 0 / 148 runs failed over last 7 days	44.59% (66) 66 / 148 runs flaked over last 7 days

---

📄   functional/plugins/plot/logPlot.e2e.spec.js • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Log plot tests Log Plot ticks are functionally correct in regular and log mode and after refresh Retry 1 • Initial Attempt	1.97% (3) 3 / 152 runs failed over last 7 days	37.50% (57) 57 / 152 runs flaked over last 7 days

---

📄   functional/plugins/plot/tagging.e2e.spec.js • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Plot Tagging Tags work with Overlay Plots Retry 1 • Initial Attempt	10.67% (16) 16 / 150 runs failed over last 7 days	28.67% (43) 43 / 150 runs flaked over last 7 days

---

View Detailed Build Results

---

[codecov]

Codecov Report

Merging #6938 (8c69757) into master (a495e86) will decrease coverage by 3.04%.
The diff coverage is n/a.

❗ Current head 8c69757 differs from pull request most recent head b8a3d19. Consider uploading reports for the commit b8a3d19 to get more accurate results

@@            Coverage Diff             @@
##           master    #6938      +/-   ##
==========================================
- Coverage   48.31%   45.28%   -3.04%     
==========================================
  Files         643      643              
  Lines       25719    25719              
  Branches     2512     2512              
==========================================
- Hits        12427    11646     -781     
- Misses      12812    13574     +762     
- Partials      480      499      +19     

Flag	Coverage Δ		*Carryforward flag
e2e-full	42.11% <ø> (+0.11%)	⬆️	Carriedforward from 5602619
e2e-stable	41.30% <ø> (-15.93%)	⬇️
unit	39.36% <ø> (+0.68%)	⬆️

*This pull request uses carry forward flags. Click here to find out more.

see 127 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a495e86...b8a3d19. Read the comment docs.

[evenstensberg]

@unlikelyzero ptal

[unlikelyzero]

@evenstensberg please update our readme with the use of nvm use where you think it's the most appropriate.

I think maybe here:

openmct/README.md

Line 50 in a495e86

## Compatibility

[evenstensberg]

@unlikelyzero I also added nvm in installation step, ptal

[unlikelyzero]

I would mention that this is optional

[unlikelyzero]

Can you update this as an optional and it'll be good to go

[evenstensberg]

@unlikelyzero ✅