-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eslint): sort import rule #6939
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6939 +/- ##
==========================================
- Coverage 48.83% 48.33% -0.50%
==========================================
Files 643 643
Lines 25730 25629 -101
Branches 2512 2496 -16
==========================================
- Hits 12565 12388 -177
- Misses 12670 12764 +94
+ Partials 495 477 -18
*This pull request uses carry forward flags. Click here to find out more.
... and 15 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Current Playwright Test Results Summary✅ 136 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 08/31/2023 08:33:18pm UTC)
|
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Log plot tests Log Plot ticks are functionally correct in regular and log mode and after refresh
Retry 1 • Initial Attempt |
2.60% (2)2 / 77 runsfailed over last 7 days |
36.36% (28)28 / 77 runsflaked over last 7 days |
📄 functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1 • Initial Attempt |
0% (0)0 / 73 runsfailed over last 7 days |
49.32% (36)36 / 73 runsflaked over last 7 days |
📄 functional/planning/timelist.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1 • Initial Attempt |
0% (0)0 / 106 runsfailed over last 7 days |
48.11% (51)51 / 106 runsflaked over last 7 days |
This should be added after UMD -> ESM |
Do you think it would cause us any issues if we add it before this is completed? This is great and I would like to incorporate it into our eslint config. |
@ozyx You can run the plugin without any issues (se eslintrc for rules to toggle). This plugin is very simple, as it says. |
@ozyx PTAL! Atm I've configured to only have warnings on import/export rules. You can fix those pretty easily. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff. Thank you!
Closes #7023
Describe your changes:
Rule to sort imports.
https://github.com/lydell/eslint-plugin-simple-import-sort
All Submissions:
Author Checklist
Reviewer Checklist