Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint): sort import rule #6939

Merged
merged 5 commits into from
Aug 31, 2023
Merged

Conversation

evenstensberg
Copy link
Contributor

@evenstensberg evenstensberg commented Aug 15, 2023

Closes #7023

Describe your changes:

Rule to sort imports.

https://github.com/lydell/eslint-plugin-simple-import-sort

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #6939 (f94d320) into master (e09a7ae) will decrease coverage by 0.50%.
The diff coverage is 37.83%.

❗ Current head f94d320 differs from pull request most recent head 2b3a6e5. Consider uploading reports for the commit 2b3a6e5 to get more accurate results

@@            Coverage Diff             @@
##           master    #6939      +/-   ##
==========================================
- Coverage   48.83%   48.33%   -0.50%     
==========================================
  Files         643      643              
  Lines       25730    25629     -101     
  Branches     2512     2496      -16     
==========================================
- Hits        12565    12388     -177     
- Misses      12670    12764      +94     
+ Partials      495      477      -18     
Flag Coverage Δ *Carryforward flag
e2e-full 42.04% <ø> (+0.01%) ⬆️ Carriedforward from a976cac
e2e-stable 57.10% <ø> (-0.16%) ⬇️
unit 38.75% <37.83%> (-0.75%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
example/eventGenerator/plugin.js 100.00% <ø> (ø)
example/exampleUser/ExampleUserProvider.js 88.46% <ø> (ø)
example/generator/plugin.js 90.00% <ø> (ø)
src/api/actions/ActionsAPI.js 96.07% <ø> (ø)
src/api/annotation/AnnotationAPI.js 90.51% <ø> (ø)
src/api/composition/CompositionAPI.js 100.00% <ø> (ø)
src/api/composition/CompositionProvider.js 73.68% <ø> (ø)
src/api/composition/DefaultCompositionProvider.js 95.45% <ø> (ø)
src/api/forms/FormController.js 96.00% <ø> (ø)
src/api/forms/FormsAPI.js 94.87% <ø> (ø)
... and 218 more

... and 15 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e09a7ae...2b3a6e5. Read the comment docs.

@deploysentinel
Copy link

deploysentinel bot commented Aug 15, 2023

Current Playwright Test Results Summary

✅ 136 Passing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/31/2023 08:33:18pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 2b3a6e5

Started: 08/31/2023 08:26:50pm UTC

⚠️ Flakes

📄   functional/plugins/plot/logPlot.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Log plot tests Log Plot ticks are functionally correct in regular and log mode and after refresh
Retry 1Initial Attempt
2.60% (2) 2 / 77 runs
failed over last 7 days
36.36% (28) 28 / 77 runs
flaked over last 7 days

📄   functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1Initial Attempt
0% (0) 0 / 73 runs
failed over last 7 days
49.32% (36) 36 / 73 runs
flaked over last 7 days

📄   functional/planning/timelist.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1Initial Attempt
0% (0) 0 / 106 runs
failed over last 7 days
48.11% (51) 51 / 106 runs
flaked over last 7 days

View Detailed Build Results


@ozyx ozyx added the source:community Community contribution or request label Aug 15, 2023
@evenstensberg
Copy link
Contributor Author

This should be added after UMD -> ESM

@ozyx ozyx self-requested a review August 30, 2023 22:32
@ozyx
Copy link
Contributor

ozyx commented Aug 30, 2023

This should be added after UMD -> ESM

Do you think it would cause us any issues if we add it before this is completed? This is great and I would like to incorporate it into our eslint config.

package.json Outdated Show resolved Hide resolved
@evenstensberg
Copy link
Contributor Author

evenstensberg commented Aug 31, 2023

@ozyx You can run the plugin without any issues (se eslintrc for rules to toggle). This plugin is very simple, as it says.

@evenstensberg
Copy link
Contributor Author

@ozyx PTAL! Atm I've configured to only have warnings on import/export rules. You can fix those pretty easily.

@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 31, 2023
@ozyx ozyx added pr:e2e:couchdb npm run test:e2e:couchdb and removed pr:e2e:couchdb npm run test:e2e:couchdb labels Aug 31, 2023
Copy link
Contributor

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff. Thank you!

@ozyx ozyx merged commit c27ad46 into nasa:master Aug 31, 2023
9 checks passed
ozyx added a commit that referenced this pull request Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:e2e:couchdb npm run test:e2e:couchdb source:community Community contribution or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Infra]: add eslint plugin that sorts imports correctly
2 participants