-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Progress Bar Display #6952
Progress Bar Display #6952
Conversation
Current Playwright Test Results Summary✅ 136 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 08/18/2023 10:54:40pm UTC)
|
|
2 Test Cases Affected |
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1 • Initial Attempt |
0% (0)0 / 154 runsfailed over last 7 days |
43.51% (67)67 / 154 runsflaked over last 7 days |
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1 • Initial Attempt |
0% (0)0 / 153 runsfailed over last 7 days |
42.48% (65)65 / 153 runsflaked over last 7 days |
📄 functional/plugins/plot/tagging.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Plot Tagging Tags work with Overlay Plots
Retry 1 • Initial Attempt |
11.11% (17)17 / 153 runsfailed over last 7 days |
26.14% (40)40 / 153 runsflaked over last 7 days |
Codecov Report
@@ Coverage Diff @@
## master #6952 +/- ##
==========================================
- Coverage 48.69% 46.87% -1.83%
==========================================
Files 643 643
Lines 25719 25719
Branches 2512 2512
==========================================
- Hits 12525 12056 -469
- Misses 12692 13182 +490
+ Partials 502 481 -21
*This pull request uses carry forward flags. Click here to find out more. see 62 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! This LGTM. Thank you!
@@ -25,6 +25,7 @@ | |||
&__bar { | |||
background: $colorProgressBar; | |||
height: 100%; | |||
min-height: $progressBarMinH; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice catch!
Closes #6516
Describe your changes:
Added Minimum height to progress bar, bar
Testing
I added
<progress-bar :model=" {progressPerc: 74}" />
to Webpage.vue (don't forgetimport ProgressBar from '../../../ui/components/ProgressBar.vue'
right after <script> andcomponents: { ProgressBar },
before inject)All Submissions:
Author Checklist
Reviewer Checklist