Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick(#6929): Condition sets now provide the timeContext they're using when sending requests #6959

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

shefalijoshi
Copy link
Contributor

@shefalijoshi shefalijoshi commented Aug 18, 2023

Original issue: #6928

… using when sending requests (#6929)

* Send in the timeContext for requests

* Fix failing test

---------

Co-authored-by: Scott Bell <[email protected]>
@deploysentinel
Copy link

deploysentinel bot commented Aug 18, 2023

Current Playwright Test Results Summary

✅ 14 Passing

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/18/2023 04:33:05pm UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: 42dc55e

Started: 08/18/2023 04:26:49pm UTC

View Detailed Build Results


Current Playwright Test Results Summary

✅ 137 Passing - ⚠️ 5 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/18/2023 04:33:05pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 42dc55e

Started: 08/18/2023 04:25:40pm UTC

⚠️ Flakes

📄   functional/plugins/displayLayout/displayLayout.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Display Layout independent time works with display layouts and its children
Retry 1Initial Attempt
0% (0) 0 / 169 runs
failed over last 7 days
1.18% (2) 2 / 169 runs
flaked over last 7 days

📄   functional/plugins/telemetryTable/telemetryTable.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Telemetry Table unpauses and filters data when paused by button and user changes bounds
Retry 1Initial Attempt
3.52% (5) 5 / 142 runs
failed over last 7 days
16.20% (23) 23 / 142 runs
flaked over last 7 days

📄   functional/plugins/conditionSet/conditionSet.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Basic Condition Set Use ConditionSet should output blank instead of the default value
Retry 1Initial Attempt
13.33% (12) 12 / 90 runs
failed over last 7 days
32.22% (29) 29 / 90 runs
flaked over last 7 days

📄   functional/plugins/plot/tagging.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Plot Tagging Tags work with Overlay Plots
Retry 2Retry 1Initial Attempt
11.03% (16) 16 / 145 runs
failed over last 7 days
24.83% (36) 36 / 145 runs
flaked over last 7 days

📄   functional/plugins/plot/autoscale.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Autoscale User can set autoscale with a valid range @snapshot
Retry 1Initial Attempt
0% (0) 0 / 147 runs
failed over last 7 days
5.44% (8) 8 / 147 runs
flaked over last 7 days

View Detailed Build Results


@ozyx ozyx changed the title cherry-pick(6929): Condition sets now provide the timeContext they're using when sending requests (#6929) cherry-pick(#6929): Condition sets now provide the timeContext they're using when sending requests Aug 18, 2023
@ozyx ozyx added this to the Target:3.0.1 milestone Aug 18, 2023
@ozyx
Copy link
Member

ozyx commented Aug 18, 2023

Please add a link to the issue(s) the original PR is closing in the body of the cherry-pick PR for traceability

Copy link
Contributor

@davetsay davetsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davetsay davetsay self-requested a review August 21, 2023 18:27
@ozyx ozyx merged commit c3ac07e into release/3.0.1 Aug 21, 2023
13 of 19 checks passed
@ozyx ozyx deleted the cherry-pick-6929 branch August 21, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants