-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(readme): indent correctly #6996
Conversation
Current Playwright Test Results Summary✅ 136 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 08/28/2023 07:59:08pm UTC)
|
|
2 Test Cases Affected |
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1 • Initial Attempt |
3.03% (2)2 / 66 runsfailed over last 7 days |
42.42% (28)28 / 66 runsflaked over last 7 days |
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1 • Initial Attempt |
0% (0)0 / 64 runsfailed over last 7 days |
39.06% (25)25 / 64 runsflaked over last 7 days |
📄 functional/plugins/imagery/exampleImagery.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Example Imagery Object Can use Mouse Wheel to zoom in and out of latest image
Retry 1 • Initial Attempt |
1.47% (1)1 / 68 runfailed over last 7 days |
5.88% (4)4 / 68 runsflaked over last 7 days |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for improving our docs! I have a small suggestion regarding formatting.
Codecov Report
@@ Coverage Diff @@
## master #6996 +/- ##
==========================================
- Coverage 46.87% 42.03% -4.84%
==========================================
Files 643 410 -233
Lines 25730 12710 -13020
Branches 2512 0 -2512
==========================================
- Hits 12061 5343 -6718
+ Misses 13188 7367 -5821
+ Partials 481 0 -481
see 472 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
I did a revise. lmk if this is better. (It looks like it! :) ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again. Just a couple of nitpicks and then this is good to go.
Co-authored-by: Jesse Mazzella <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thank you!
np anytime |
Describe your changes:
The padding in the get started section was weird.
All Submissions:
Author Checklist
Reviewer Checklist