Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(readme): indent correctly #6996

Merged
merged 7 commits into from
Aug 28, 2023
Merged

fix(readme): indent correctly #6996

merged 7 commits into from
Aug 28, 2023

Conversation

evenstensberg
Copy link
Contributor

@evenstensberg evenstensberg commented Aug 26, 2023

Describe your changes:

The padding in the get started section was weird.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@deploysentinel
Copy link

deploysentinel bot commented Aug 26, 2023

Current Playwright Test Results Summary

✅ 136 Passing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/28/2023 07:59:08pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 43a7436

Started: 08/28/2023 07:52:34pm UTC

⚠️ Flakes

📄   functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1Initial Attempt
3.03% (2) 2 / 66 runs
failed over last 7 days
42.42% (28) 28 / 66 runs
flaked over last 7 days
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1Initial Attempt
0% (0) 0 / 64 runs
failed over last 7 days
39.06% (25) 25 / 64 runs
flaked over last 7 days

📄   functional/plugins/imagery/exampleImagery.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Example Imagery Object Can use Mouse Wheel to zoom in and out of latest image
Retry 1Initial Attempt
1.47% (1) 1 / 68 run
failed over last 7 days
5.88% (4) 4 / 68 runs
flaked over last 7 days

View Detailed Build Results


@ozyx ozyx added the source:community Community contribution or request label Aug 28, 2023
Copy link
Contributor

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving our docs! I have a small suggestion regarding formatting.

README.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #6996 (c75de6e) into master (a8678aa) will decrease coverage by 4.84%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Current head c75de6e differs from pull request most recent head 43a7436. Consider uploading reports for the commit 43a7436 to get more accurate results

@@            Coverage Diff             @@
##           master    #6996      +/-   ##
==========================================
- Coverage   46.87%   42.03%   -4.84%     
==========================================
  Files         643      410     -233     
  Lines       25730    12710   -13020     
  Branches     2512        0    -2512     
==========================================
- Hits        12061     5343    -6718     
+ Misses      13188     7367    -5821     
+ Partials      481        0     -481     
Flag Coverage Δ
e2e-full 42.03% <ø> (ø)
e2e-stable ?
unit ?

see 472 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbac2c1...43a7436. Read the comment docs.

@evenstensberg
Copy link
Contributor Author

I did a revise. lmk if this is better. (It looks like it! :) )

Copy link
Contributor

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again. Just a couple of nitpicks and then this is good to go.

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you!

@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 28, 2023
@ozyx ozyx enabled auto-merge (squash) August 28, 2023 19:43
@ozyx ozyx disabled auto-merge August 28, 2023 19:43
@ozyx ozyx enabled auto-merge (squash) August 28, 2023 19:43
@evenstensberg
Copy link
Contributor Author

np anytime

@ozyx ozyx added pr:e2e:couchdb npm run test:e2e:couchdb and removed pr:e2e:couchdb npm run test:e2e:couchdb labels Aug 28, 2023
@ozyx ozyx merged commit f9db643 into nasa:master Aug 28, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:e2e:couchdb npm run test:e2e:couchdb source:community Community contribution or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants